From: Joe Perches <joe@perches.com>
To: shuahkhan@gmail.com
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
rpurdie@linux.intel.com
Subject: Re: [PATCH] leds: simple_strtoul-cleanup
Date: Sun, 08 Apr 2012 13:20:53 -0700 [thread overview]
Message-ID: <1333916453.1801.2.camel@joe2Laptop> (raw)
In-Reply-To: <1333916003.2845.6.camel@lorien2>
On Sun, 2012-04-08 at 14:13 -0600, Shuah Khan wrote:
> led-class.c and ledtri-timer.c still use simple_strtoul().
> Change leds to use kstrtoul() instead of obsolete simple_strtoul().
[]
> @@ -44,23 +44,19 @@ static ssize_t led_brightness_store(struct device *dev,
> struct device_attribute *attr, const char *buf, size_t size)
[]
> diff --git a/drivers/leds/ledtrig-timer.c b/drivers/leds/ledtrig-timer.c
> @@ -31,21 +31,18 @@ static ssize_t led_delay_on_store(struct device *dev,
> struct device_attribute *attr, const char *buf, size_t size)
[]
> static ssize_t led_delay_off_show(struct device *dev,
[]
> +out:
> + return size;
These now don't return -EINVAL, is that a problem
for any caller?
next prev parent reply other threads:[~2012-04-08 20:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-08 20:13 [PATCH] leds: simple_strtoul-cleanup Shuah Khan
2012-04-08 20:20 ` Joe Perches [this message]
2012-04-09 14:26 ` Shuah Khan
2012-04-09 16:11 ` [PATCH v2] " Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1333916453.1801.2.camel@joe2Laptop \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@linux.intel.com \
--cc=shuahkhan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox