Re: [PATCH] leds: simple_strtoul-cleanup

[Shuah Khan <shuahkhan@gmail.com>]

On Sun, 2012-04-08 at 13:20 -0700, Joe Perches wrote:
> On Sun, 2012-04-08 at 14:13 -0600, Shuah Khan wrote:
> > led-class.c and ledtri-timer.c still use simple_strtoul(). 
> > Change leds to use kstrtoul() instead of obsolete simple_strtoul().
> []
> > @@ -44,23 +44,19 @@ static ssize_t led_brightness_store(struct device *dev,
> >  		struct device_attribute *attr, const char *buf, size_t size)
> [] 
> > diff --git a/drivers/leds/ledtrig-timer.c b/drivers/leds/ledtrig-timer.c
> > @@ -31,21 +31,18 @@ static ssize_t led_delay_on_store(struct device *dev,
> >  		struct device_attribute *attr, const char *buf, size_t size)
> []
> >  static ssize_t led_delay_off_show(struct device *dev,
> []
> > +out:
> > +	return size;
> 
> These now don't return -EINVAL, is that a problem
> for any caller?

I looked at the other _store() interfaces in leds - there is no
consistent EINVAL return. However, it would be an easy change to make to
have these return EINVAL in case of error like they used to. I can send
an updated patch.

-- Shuah