From: Tomoya MORINAGA <tomoya.rohm@gmail.com>
To: Alan Stern <stern@rowland.harvard.edu>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: qi.wang@intel.com, yong.y.wang@intel.com, joel.clark@intel.com,
kok.howg.ewe@intel.com, Tomoya MORINAGA <tomoya.rohm@gmail.com>
Subject: [PATCH 2/2] usb/ehci-pci: Add workaround for EG20T/ML7213/ML7223/ML7831
Date: Tue, 10 Apr 2012 13:07:15 +0900 [thread overview]
Message-ID: <1334030835-4681-2-git-send-email-tomoya.rohm@gmail.com> (raw)
In-Reply-To: <1334030835-4681-1-git-send-email-tomoya.rohm@gmail.com>
ISSUE: When a bit of EHCI status register (USBSTS) is set
as 1, if the corresponded bit of EHCI interrupt enable
register(USBINTR) is set as 1, an interrupt occurs.
After that, even if the bit of USBINTR is set as 0, the
interrupt continues occurring.
Workaround: Clear the bit 3 of USBSTS before enabling the
interrupt, at resume process.
This patch is for
Intel EG20T PCH
LAPIS Semiconductor ML7213 IOH
LAPIS Semiconductor ML7223 IOH
LAPIS Semiconductor ML7831 IOH
Signed-off-by: Tomoya MORINAGA <tomoya.rohm@gmail.com>
---
drivers/usb/host/ehci-pci.c | 24 ++++++++++++++++++++++++
1 files changed, 24 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/host/ehci-pci.c b/drivers/usb/host/ehci-pci.c
index 01bb7241d..30f3ad6 100644
--- a/drivers/usb/host/ehci-pci.c
+++ b/drivers/usb/host/ehci-pci.c
@@ -419,6 +419,30 @@ static int ehci_pci_resume(struct usb_hcd *hcd, bool hibernated)
ehci_prepare_ports_for_controller_resume(ehci);
if (!hcd->self.root_hub->do_remote_wakeup)
mask &= ~STS_PCD;
+
+ if ((pdev->vendor == PCI_VENDOR_ID_INTEL &&
+ pdev->device == 0x8807) ||
+ (pdev->vendor == PCI_VENDOR_ID_INTEL &&
+ pdev->device == 0x880F) ||
+ (pdev->vendor == 0x10DB &&
+ pdev->device == 0x801C) || /* ML7213 */
+ (pdev->vendor == 0x10DB &&
+ pdev->device == 0x8007) || /* ML7223 */
+ (pdev->vendor == 0x10DB &&
+ pdev->device == 0x8807)) { /* ML7831 */
+ /* ISSUE: When a bit of EHCI status register (USBSTS) is set
+ * as 1, if the corresponded bit of EHCI interrupt enable
+ * register(USBINTR) is set as 1, an interrupt occurs.
+ * After that, even if the bit of USBINTR is set as 0, the
+ * interrupt continues occurring.
+ * Workaround: Clear the bit 3 of USBSTS before enabling the
+ * interrupt, at resume process.
+ */
+ ehci_writel(ehci, STS_FLR, &ehci->regs->status);
+ ehci_dbg(ehci, "Workaround: %s: Clear STS_FLR\n",
+ __func__);
+ }
+
ehci_writel(ehci, mask, &ehci->regs->intr_enable);
ehci_readl(ehci, &ehci->regs->intr_enable);
return 0;
--
1.7.7.6
next prev parent reply other threads:[~2012-04-10 4:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-10 4:07 [PATCH 1/2] usb/ehci-hub: Add workaround for EG20T/ML7213/ML7223/ML7831 Tomoya MORINAGA
2012-04-10 4:07 ` Tomoya MORINAGA [this message]
2012-04-10 12:37 ` Sergei Shtylyov
2012-04-10 14:57 ` Alan Stern
2012-04-18 10:22 ` Tomoya MORINAGA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334030835-4681-2-git-send-email-tomoya.rohm@gmail.com \
--to=tomoya.rohm@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joel.clark@intel.com \
--cc=kok.howg.ewe@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=qi.wang@intel.com \
--cc=stern@rowland.harvard.edu \
--cc=yong.y.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox