Re: [PATCH V2 2/2] staging: Documentation: add proximity_sampling_period as sysfs details

Laxman Dewangan
2012-04-12T10:00:07Z

On Thursday 12 April 2012 03:07 PM, Jonathan Cameron wrote:
> On 4/12/2012 8:08 AM, Laxman Dewangan wrote:
>> +What: /sys/bus/iio/devices/device[n]/proximity_sampling_period
>> +KernelVersion: 3.5
>> +Contact: linux-iio@vger.kernel.org
>> +Description:
>> + Hardware dependent mode for proximity sensor device to set/get
>> + the sampling rate of proximity sensing and conversion.
> Ah, that explains what it is. Sorry, use
> in_proximitiy0_sampling_frequency to provide equivalent
> control please. Might be a pain here, but this interface will just
> provide the same info as the existing
> one in a different form. Note that sampling_frequency is documented as
> a general one, but can
> be extended to individual channels.
>

Ooop, I did not realize that it is there as part of sysfs.h. I was
looking for other header to get support for this. I can use this for
proximity only but I think I should go with you other suggestion to
implement this on channel basis. This will help also in future for other
drivers to have different sampling on different channel.
> Actually add it to the iio-core as an element in the info_mask as I
> doubt this will be the last time
> we see this control. This will need to be a precursor patch to the
> driver obviously.
>
> IIO_CHAN_INFO_SAMP_FREQ and the relevant shared and separate macros need
> to go in
> iio.h + the text entry in industrialio-core.c
>
> If you like I can do this but it'll be quicker if you do :)

I will send the patch for implementing this first and then modified
version of my driver which actually uses this one.