From: Artem Bityutskiy <dedekind1@gmail.com>
To: subodh.nijsure@gmail.com
Cc: linux-mtd@lists.infradead.org,
Adrian Hunter <adrian.hunter@intel.com>,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org,
Subodh Nijsure <snijsure@grid-net.com>
Subject: Re: [PATCH v3] Add security.* XATTR support for the UBIFS
Date: Thu, 12 Apr 2012 10:11:53 +0300 [thread overview]
Message-ID: <1334214713.13842.34.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <1334179707-31754-1-git-send-email-snijsure@grid-net.com>
[-- Attachment #1: Type: text/plain, Size: 614 bytes --]
On Wed, 2012-04-11 at 14:28 -0700, subodh.nijsure@gmail.com wrote:
> +#ifdef CONFIG_UBIFS_FS_XATTR
> +
> + err = ubifs_init_security(dir, inode, &dentry->d_name);
> + if (err) {
> + ubifs_err("cannot initialize extended attribute, error %d",
> + err);
> + goto out_cancel;
> + }
> +
> +#endif
Suboodh,
would you please first create a preparational patch which removes
the CONFIG_UBIFS_FS_XATTR completely and makes xattr support to be
always present.
And then you could add the security stuff on top of this without the
#ifdef churn.
Thanks!
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-04-12 7:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-11 21:28 [PATCH v3] Add security.* XATTR support for the UBIFS subodh.nijsure
2012-04-11 23:27 ` Mimi Zohar
2012-04-11 23:45 ` Subodh Nijsure
2012-04-12 0:08 ` Mimi Zohar
2012-04-12 7:11 ` Artem Bityutskiy [this message]
2012-04-13 13:41 ` Stephen Smalley
-- strict thread matches above, loose matches on Subject: below --
2012-05-10 23:17 Subodh Nijsure
2012-05-11 12:01 ` Tetsuo Handa
2012-05-11 14:25 ` Subodh Nijsure
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334214713.13842.34.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-security-module@vger.kernel.org \
--cc=snijsure@grid-net.com \
--cc=subodh.nijsure@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox