From: Axel Lin <axel.lin@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Linus Walleij <linus.walleij@stericsson.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Liam Girdwood <lrg@ti.com>
Subject: [PATCH RFT 1/3] regulator: ab3100: Add dummy set_suspend_[enable|disable] callbacks implementation
Date: Fri, 13 Apr 2012 12:41:38 +0800 [thread overview]
Message-ID: <1334292098.6122.1.camel@phoenix> (raw)
Without the implementation of set_suspend_enable and set_suspend_disable callbacks,
the regulator core won't call set_suspend_voltage.
Thus add dummy implementation for set_suspend_[enable|disable] callbacks.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/regulator/ab3100.c | 16 +++++++++++++++-
1 files changed, 15 insertions(+), 1 deletions(-)
diff --git a/drivers/regulator/ab3100.c b/drivers/regulator/ab3100.c
index ce61925..b08d92b 100644
--- a/drivers/regulator/ab3100.c
+++ b/drivers/regulator/ab3100.c
@@ -367,6 +367,17 @@ static int ab3100_set_voltage_regulator_sel(struct regulator_dev *reg,
return err;
}
+/* Dummy set_suspend_enable/set_suspend_disable callbacks implementation */
+static int ab3100_set_suspend_enable(struct regulator_dev *rdev)
+{
+ return 0;
+}
+
+static int ab3100_set_suspend_disable(struct regulator_dev *rdev)
+{
+ return 0;
+}
+
static int ab3100_set_suspend_voltage_regulator(struct regulator_dev *reg,
int uV)
{
@@ -467,9 +478,12 @@ static struct regulator_ops regulator_ops_variable_sleepable = {
.is_enabled = ab3100_is_enabled_regulator,
.get_voltage = ab3100_get_voltage_regulator,
.set_voltage_sel = ab3100_set_voltage_regulator_sel,
- .set_suspend_voltage = ab3100_set_suspend_voltage_regulator,
.list_voltage = ab3100_list_voltage_regulator,
.enable_time = ab3100_enable_time_regulator,
+
+ .set_suspend_enable = ab3100_set_suspend_enable,
+ .set_suspend_disable = ab3100_set_suspend_disable,
+ .set_suspend_voltage = ab3100_set_suspend_voltage_regulator,
};
/*
--
1.7.5.4
next reply other threads:[~2012-04-13 4:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-13 4:41 Axel Lin [this message]
2012-04-13 4:42 ` [PATCH RFT 2/3] regulator: wm831x-dcdc: Add dummy set_suspend_[enable|disable] callbacks implementation Axel Lin
2012-04-13 4:43 ` [PATCH RFT 3/3] regulator: wm831x-ldo: " Axel Lin
2012-04-13 8:16 ` [PATCH RFT 1/3] regulator: ab3100: " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334292098.6122.1.camel@phoenix \
--to=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox