From: Chris Wilson <chris@chris-wilson.co.uk>
To: Daniel Kurtz <djkurtz@chromium.org>,
Keith Packard <keithp@keithp.com>,
David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Daniel Vetter <daniel@ffwll.ch>
Cc: Daniel Kurtz <djkurtz@chromium.org>
Subject: Re: [PATCH 1/2] drm/i915/intel_i2c: handle zero-length reads
Date: Fri, 13 Apr 2012 13:25:33 +0100 [thread overview]
Message-ID: <1334319941_407751@CP5-2952> (raw)
In-Reply-To: <1334317674-32450-1-git-send-email-djkurtz@chromium.org>
On Fri, 13 Apr 2012 19:47:53 +0800, Daniel Kurtz <djkurtz@chromium.org> wrote:
> A common method of probing an i2c bus is trying to do a zero-length read.
> Handle this case by checking the length first waiting for data to be read.
>
> This is actually important, since attempting a zero-length read is one
> of the ways that i2cdetect and i2c_new_probed_device detect whether
> there is device present on the bus with a given address.
>
> Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
You earlier assuaged my fears that setting SW_READY without waiting
would anger the hw, so
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-04-13 12:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-13 11:47 [PATCH 1/2] drm/i915/intel_i2c: handle zero-length reads Daniel Kurtz
2012-04-13 11:47 ` [PATCH 2/2] drm/i915/intel_i2c: reduce verbosity of some messages Daniel Kurtz
2012-04-13 13:04 ` Daniel Vetter
2012-04-13 12:25 ` Chris Wilson [this message]
2012-04-13 12:26 ` [PATCH 1/2] drm/i915/intel_i2c: handle zero-length reads Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334319941_407751@CP5-2952 \
--to=chris@chris-wilson.co.uk \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=djkurtz@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=keithp@keithp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox