From: Artem Bityutskiy <dedekind1@gmail.com>
To: Josh Cartwright <joshc@linux.com>,
Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
Cc: Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] jffs2: Fix lock acquisition order bug in gc path
Date: Fri, 13 Apr 2012 18:14:00 +0300 [thread overview]
Message-ID: <1334330040.2544.79.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <20120329233453.GA23698@joshcartwright.net>
[-- Attachment #1: Type: text/plain, Size: 645 bytes --]
On Thu, 2012-03-29 at 19:34 -0400, Josh Cartwright wrote:
> The locking policy is such that the erase_complete_block spinlock is
> nested within the alloc_sem mutex. This fixes a case in which the
> acquisition order was erroneously reversed. This issue was caught by
> the following lockdep splat:
I've added the follwing:
This was introduce in '81cfc9f jffs2: Fix serious write stall due to
erase'.
Cc: stable@kernel.org [2.6.37+]
and pushed to l2-mtd.git, thanks! CC-in Joakim to let him know that his
patch has a bug and that he might want this fix in his system(s) as
well.
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-04-13 15:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-09 18:50 [PATCH] jffs2: Fix lock acquisition order bug in gc path Josh Cartwright
2012-03-29 15:38 ` Brian Norris
2012-03-29 23:29 ` Josh Cartwright
2012-03-29 23:34 ` [PATCH V2] " Josh Cartwright
2012-04-13 15:14 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334330040.2544.79.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=Joakim.Tjernlund@transmode.se \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=joshc@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).