From: Peter Zijlstra <peterz@infradead.org>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: torvalds@linux-foundation.org, akpm@linux-foundation.org,
mingo@elte.hu, hpa@zytor.com, tglx@linutronix.de,
srivatsa.bhat@linux.vnet.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: [RFC 3/3] kernel.h: use new typechecking macros in min()/max() and friends
Date: Sat, 14 Apr 2012 23:01:28 +0200 [thread overview]
Message-ID: <1334437288.2528.111.camel@twins> (raw)
In-Reply-To: <1334441685-4438-4-git-send-email-levinsasha928@gmail.com>
On Sat, 2012-04-14 at 18:14 -0400, Sasha Levin wrote:
> #define min(x, y) ({ \
> - typeof(x) _min1 = (x); \
> - typeof(y) _min2 = (y); \
> - (void) (&_min1 == &_min2); \
> - _min1 < _min2 ? _min1 : _min2; })
> + typecmp2((x), (y)); \
> + (x) < (y) ? (x) : (y); })
Problem with this is that it evaluates x and y multiple times.
next prev parent reply other threads:[~2012-04-14 21:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-14 22:14 [RFC 0/3] Extend type checking macros Sasha Levin
2012-04-14 21:02 ` Peter Zijlstra
2012-04-14 21:18 ` Srivatsa S. Bhat
2012-04-14 22:31 ` Srivatsa S. Bhat
2012-04-14 22:14 ` [RFC 1/3] typecheck: extend typecheck.h with more useful typechecking macros Sasha Levin
2012-04-14 21:12 ` Linus Torvalds
2012-04-14 22:14 ` [RFC 2/3] sched: add type checks to for_each_cpu_mask() Sasha Levin
2012-04-14 21:15 ` Linus Torvalds
2012-04-20 22:33 ` Andrew Morton
2012-04-14 22:14 ` [RFC 3/3] kernel.h: use new typechecking macros in min()/max() and friends Sasha Levin
2012-04-14 21:01 ` Peter Zijlstra [this message]
2012-04-14 21:17 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334437288.2528.111.camel@twins \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox