public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ben Hutchings <ben@decadent.org.uk>
To: Luis Henriques <luis.henriques@canonical.com>
Cc: Matthew Garrett <mjg@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: amilo-rfkill: unsupported platform
Date: Mon, 16 Apr 2012 14:46:01 +0100	[thread overview]
Message-ID: <1334583961.3209.112.camel@deadeye> (raw)
In-Reply-To: <20120416131216.GA4047@zeus>

[-- Attachment #1: Type: text/plain, Size: 913 bytes --]

On Mon, 2012-04-16 at 14:12 +0100, Luis Henriques wrote:
> Hi Ben,
> 
> You have recently submitted a new rfkill driver for the Amilo A1655 and
> M7440 models.  We have been using the fsam7400 driver[1] for the Amilo
> M7440 and it would probably make sense to merge it into the amilo-rfkill.
> 
> However, the fsam7400 driver directly invokes BIOS code in order to turn
> on/off the radio, instead of the methods used by the A1655 and M7440
> driver.

Consistency, it's a wonderful thing.

> This means the memory pages with the BIOS code would need to be
> set as executable after the ioremap (which is probably a bad idea).
> 
> Are there any plans of merging this driver into the amilo-rfkill driver?

I have no plans for this, but feel free to try it.

Ben.

> [1] http://www.iragan.com/linux/fsam7400/

-- 
Ben Hutchings
This sentence contradicts itself - no actually it doesn't.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

  reply	other threads:[~2012-04-16 13:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-16 13:12 amilo-rfkill: unsupported platform Luis Henriques
2012-04-16 13:46 ` Ben Hutchings [this message]
2012-04-16 19:35   ` Luis Henriques

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1334583961.3209.112.camel@deadeye \
    --to=ben@decadent.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luis.henriques@canonical.com \
    --cc=mjg@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox