From: Toshi Kani <toshi.kani@hp.com>
To: shuahkhan@gmail.com
Cc: Jiang Liu <liuj97@gmail.com>,
lenb@kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] ACPI: Add _OST support for ACPI hotplug
Date: Mon, 16 Apr 2012 12:24:16 -0600 [thread overview]
Message-ID: <1334600656.20190.139.camel@misato.fc.hp.com> (raw)
In-Reply-To: <1334342089.3422.5.camel@lorien2>
On Fri, 2012-04-13 at 12:34 -0600, Shuah Khan wrote:
> > I would like to explain more detail about my testing. Unlike other ACPI
> > methods, the functionality of _OST method is not defined by the spec.
> > It is all up to the firmware implementation.
>
> A good reason why this patch requires more testing than on simulated
> firmware code that is based on one single firmware implementation.
Thanks Shuah for the guidance. Do they summarize your point properly?
1. Testing a new feature on simulated / virtualized environment alone is
not sufficient.
2. Pre-enablement of a new feature is not allowed.
3. Contributing code that supports a new feature shall wait until there
are multiple firmware implementations available for the testing.
I like clear guidance, but this may be challenging for emerging
features.
-Toshi
prev parent reply other threads:[~2012-04-16 18:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-10 22:21 [PATCH 0/5] ACPI: Add _OST support for ACPI hotplug Toshi Kani
2012-04-10 22:21 ` [PATCH 1/4] ACPI: Set hotplug _OST support bit to _OSC Toshi Kani
2012-04-26 15:16 ` Bjorn Helgaas
2012-04-26 17:10 ` Toshi Kani
2012-04-27 22:05 ` Toshi Kani
2012-05-02 21:20 ` Toshi Kani
2012-04-10 22:21 ` [PATCH 2/4] ACPI: Add acpi_evaluate_ost() for calling _OST Toshi Kani
2012-04-10 22:21 ` [PATCH 3/4] ACPI: Add _OST support for ACPI CPU hotplug Toshi Kani
2012-04-26 15:22 ` Bjorn Helgaas
2012-04-26 17:20 ` Toshi Kani
2012-04-10 22:21 ` [PATCH 4/4] ACPI: Add _OST support for ACPI memory hotplug Toshi Kani
2012-04-11 16:33 ` [PATCH 0/5] ACPI: Add _OST support for ACPI hotplug Shuah Khan
2012-04-11 18:50 ` Toshi Kani
2012-04-12 14:19 ` Shuah Khan
2012-04-13 14:24 ` Jiang Liu
2012-04-13 15:23 ` Shuah Khan
2012-04-13 16:05 ` Toshi Kani
2012-04-13 18:34 ` Shuah Khan
2012-04-16 18:24 ` Toshi Kani [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334600656.20190.139.camel@misato.fc.hp.com \
--to=toshi.kani@hp.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuj97@gmail.com \
--cc=shuahkhan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox