From: Paul Moore <pmoore@redhat.com>
To: Eric Paris <eparis@redhat.com>
Cc: Steve Grubb <sgrubb@redhat.com>,
Richard Guy Briggs <rgb@redhat.com>,
linux-audit@redhat.com, linux-kernel@vger.kernel.org,
aviro@redhat.com
Subject: Re: [PATCH V5 0/5] audit by executable name
Date: Tue, 21 Oct 2014 18:35:57 -0400 [thread overview]
Message-ID: <13346524.UcV0TUOQcF@sifl> (raw)
In-Reply-To: <1413929992.30946.59.camel@localhost>
On Tuesday, October 21, 2014 06:19:52 PM Eric Paris wrote:
> On Tue, 2014-10-21 at 17:56 -0400, Paul Moore wrote:
> > * Change the audit_status.version field comment in
> > include/uapi/linux/audit.h to "/* audit functionality bitmap */", or
> > similar. We can't really change the structure now, but the comment is
> > fair game.
>
> Trying to think how to do things with a #define so you can rename,
> "version" is pretty darn generic to pre-process. You could make it a
> union, so userspace code and use a sane name....
Yeah, I thought about suggesting the #define approach but figured that might
just be me worrying about the color of the paint ... okay, Richard, why don't
you go ahead and change the version field name and put in a #define for
compatibility.
> > Can anyone think of anything else that might be affected by this?
>
> No one uses this stuff, just change it.
Yes, but I feel like I need to at least ask the question; how much attention I
pay to the answers is something else ...
--
paul moore
security and virtualization @ redhat
next prev parent reply other threads:[~2014-10-21 22:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-03 3:06 [PATCH V5 0/5] audit by executable name Richard Guy Briggs
2014-10-03 3:06 ` [PATCH V5 1/5] audit: implement audit by executable Richard Guy Briggs
2014-10-03 3:06 ` [PATCH V5 2/5] audit: clean simple fsnotify implementation Richard Guy Briggs
2014-10-03 3:06 ` [PATCH V5 3/5] audit: convert audit_exe to audit_fsnotify Richard Guy Briggs
2014-10-03 3:06 ` [PATCH V5 4/5] audit: avoid double copying the audit_exe path string Richard Guy Briggs
2014-10-03 3:06 ` [PATCH V5 5/5] Revert "fixup! audit: clean simple fsnotify implementation" Richard Guy Briggs
2014-10-20 20:25 ` [PATCH V5 0/5] audit by executable name Steve Grubb
2014-10-20 22:47 ` Eric Paris
2014-10-20 23:02 ` Paul Moore
2014-10-20 23:33 ` Steve Grubb
2014-10-20 23:49 ` Steve Grubb
2014-10-21 21:56 ` Paul Moore
2014-10-21 22:06 ` Steve Grubb
2014-10-21 22:19 ` Eric Paris
2014-10-21 22:35 ` Paul Moore [this message]
2014-10-29 19:48 ` Richard Guy Briggs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13346524.UcV0TUOQcF@sifl \
--to=pmoore@redhat.com \
--cc=aviro@redhat.com \
--cc=eparis@redhat.com \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rgb@redhat.com \
--cc=sgrubb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox