The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Geoff Levand <geoff@infradead.org>
To: Hui Zhu <teawater@gmail.com>
Cc: linux-kernel@vger.kernel.org, zen lin <zen@openhuawei.org>
Subject: Re: KGTP (Linux Kernel debugger and tracer) 20120406 release(hotcode analyzer hotcode.py can output html) include patch for review
Date: Tue, 17 Apr 2012 18:05:17 -0700	[thread overview]
Message-ID: <1334711117.4785.43.camel@smoke> (raw)
In-Reply-To: <CANFwon0C46UWTLVSeBTTm_aUCub7qW9d+jm=71h894bRODwyQA@mail.gmail.com>

Hi Hui,

On Sat, 2012-04-07 at 20:21 +0800, Hui Zhu wrote:
> Signed-off-by: Hui Zhu <teawater@gmail.com>

You have done some interesting work, but can I recommend a
few things?

Please break your patch into a few smaller ones, say, one
that adds the core kgtp support, one that adds the
documentation files, one that adds the scripts.  Each patch
should have a suitable comment that describes the
changes.  For kgtp the patch for the core support would
of course have a discussion of the feature and its
benefits, etc.

Also, please post your patches inline so we can give
line-by-line comments.  It is difficult to give comments
when the patch is an email attachment.

-Geoff



  reply	other threads:[~2012-04-18  1:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-07 12:21 KGTP (Linux Kernel debugger and tracer) 20120406 release(hotcode analyzer hotcode.py can output html) include patch for review Hui Zhu
2012-04-18  1:05 ` Geoff Levand [this message]
2012-04-22  5:17   ` Hui Zhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1334711117.4785.43.camel@smoke \
    --to=geoff@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=teawater@gmail.com \
    --cc=zen@openhuawei.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox