From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754809Ab2DRUDV (ORCPT ); Wed, 18 Apr 2012 16:03:21 -0400 Received: from hqemgate04.nvidia.com ([216.228.121.35]:18893 "EHLO hqemgate04.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752055Ab2DRUDT (ORCPT ); Wed, 18 Apr 2012 16:03:19 -0400 X-PGP-Universal: processed; by hqnvupgp05.nvidia.com on Wed, 18 Apr 2012 13:03:19 -0700 Subject: Re: [PATCH 1/4] regulator: tps65910: update type for regmap From: Rhyland Klein To: Mark Brown Cc: Liam Girdwood , Grant Likely , Rob Herring , Samuel Ortiz , "devicetree-discuss@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "linux-tegra@vger.kernel.org" In-Reply-To: <20120418092547.GE3021@opensource.wolfsonmicro.com> References: <1334710829-22777-1-git-send-email-rklein@nvidia.com> <1334710829-22777-2-git-send-email-rklein@nvidia.com> <20120418092547.GE3021@opensource.wolfsonmicro.com> Content-Type: text/plain; charset="UTF-8" Date: Wed, 18 Apr 2012 13:03:22 -0700 Message-ID: <1334779402.32315.63.camel@rklein-linux> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2012-04-18 at 02:25 -0700, Mark Brown wrote: > * PGP Signed by an unknown key > > On Tue, Apr 17, 2012 at 06:00:26PM -0700, Rhyland Klein wrote: > > When accessing the regmap via the read/write functions, we need to use a > > unsigned int * instead of a u8 * otherwise corruption will occur. > > > > Signed-off-by: Rhyland Klein > > > static inline int tps65910_read(struct tps65910_reg *pmic, u8 reg) > > { > > - u8 val; > > + unsigned int val; > > int err; > > > > err = pmic->mfd->read(pmic->mfd, reg, 1, &val); > > Ugh, this interface is just broken all round - there's absolutely no > type safety here and all users of these functions will be broken (a > similar issue applies on write). It's much better to fix this for 3.4 > by converting the core code to use regmap_raw_ functions which take > native formatted data for the device like the function driver API > actually expects. Which interface are you saying is broken? The regmap interface or the one internal to the tps65910 code? > > Looking at the MFD code the fix for 3.5 should at the very least involve > making the functions take typed pointers, though given the way they're > implemented right now with direct references in the subdevices I'd also > consider just having the subdevices uses regmap directly as the wrappers > are just adding an opportunity for error (the bit operations could be > converted into static inlines in the header too). > So to be clear... Your recommendation is to change the tps65910 code to remove the common read/write callbacks and to use regmap directly in each component, and then when using regmap, do use the regmap raw functions instead of the bulkread/write? > * Unknown Key > * 0x6E30FDDD Thanks, rhyland --- nvpublic