From: Tejun Heo <tj@kernel.org>
To: axboe@kernel.dk
Cc: vgoyal@redhat.com, ctalbott@google.com, rni@google.com,
cgroups@vger.kernel.org, containers@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: [PATCHSET] block: fixes for long standing issues
Date: Thu, 19 Apr 2012 16:29:20 -0700 [thread overview]
Message-ID: <1334878164-24788-1-git-send-email-tj@kernel.org> (raw)
Hello,
This patchset fixes two long standing issues and one relatively new
css ref leak.
a. elvpriv alloc failure, including ioc and icq failures, fails
request allocation. As those aren't mempool backed and may fail
indefinitely, this can lead to deadlock under memory pressure.
b. blkgs don't have proper indexing. With enough number of
request_queues and blk-throttle enabled, block layer can spend
considerable amount of cpu cycles walking the same list over and
over again.
c. __blkg_lookup_create() was leaking a css ref on failure path.
This patchset contains the following four patches.
0001-block-collapse-blk_alloc_request-into-get_request.patch
0002-block-fix-elvpriv-allocation-failure-handling.patch
0003-blkcg-fix-blkcg-css-ref-leak-in-__blkg_lookup_create.patch
0004-blkcg-use-radix-tree-to-index-blkgs-from-blkcg.patch
0001-0002 fix #a. 0003 fixes #c. 0004 fixes #b.
This patchset is on top of
block/for-3.5/core 5bc4afb1ec "blkcg: drop BLKCG_STAT_{PRIV|POL|OFF} macros"
+ [1] [PATCHSET] block: per-queue policy activation, take#2
+ [2] [PATCHSET] block: cosmetic updates to blkcg API
and available in the following git branch.
git://git.kernel.org/pub/scm/linux/kernel/git/tj/misc.git blk-misc-fixes
diffstat follows.
block/blk-cgroup.c | 71 ++++++++++++++++++++++++++++++++-----------
block/blk-cgroup.h | 6 +++
block/blk-core.c | 87 ++++++++++++++++++++++++++++-------------------------
3 files changed, 106 insertions(+), 58 deletions(-)
Thanks.
--
tejun
[1] https://lkml.org/lkml/2012/4/13/380
[2] http://www.spinics.net/lists/cgroups/msg01748.html
next reply other threads:[~2012-04-19 23:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-19 23:29 Tejun Heo [this message]
2012-04-19 23:29 ` [PATCH 1/4] block: collapse blk_alloc_request() into get_request() Tejun Heo
2012-04-19 23:29 ` [PATCH 2/4] block: fix elvpriv allocation failure handling Tejun Heo
2012-04-19 23:29 ` [PATCH 3/4] blkcg: fix blkcg->css ref leak in __blkg_lookup_create() Tejun Heo
2012-04-19 23:29 ` [PATCH 4/4] blkcg: use radix tree to index blkgs from blkcg Tejun Heo
2012-04-20 17:26 ` Vivek Goyal
2012-04-20 8:10 ` [PATCHSET] block: fixes for long standing issues Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334878164-24788-1-git-send-email-tj@kernel.org \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=containers@lists.linux-foundation.org \
--cc=ctalbott@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rni@google.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox