* remove unnecessary ftrace WARN_ONCE's.
@ 2012-04-12 2:31 Dave Jones
2012-04-20 17:03 ` Dave Jones
0 siblings, 1 reply; 3+ messages in thread
From: Dave Jones @ 2012-04-12 2:31 UTC (permalink / raw)
To: Linux Kernel; +Cc: laijs, fweisbec, srostedt, mingo
These warnings are trivially triggerable by any user, and serve no useful purpose afaics
Just -EINVAL and be done.
Signed-off-by: Dave Jones <davej@redhat.com>
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index ed7b5d1..a745317 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -4136,13 +4136,11 @@ tracing_buffers_splice_read(struct file *file, loff_t *ppos,
return -ENOMEM;
if (*ppos & (PAGE_SIZE - 1)) {
- WARN_ONCE(1, "Ftrace: previous read must page-align\n");
ret = -EINVAL;
goto out;
}
if (len & (PAGE_SIZE - 1)) {
- WARN_ONCE(1, "Ftrace: splice_read should page-align\n");
if (len < PAGE_SIZE) {
ret = -EINVAL;
goto out;
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: remove unnecessary ftrace WARN_ONCE's.
2012-04-12 2:31 remove unnecessary ftrace WARN_ONCE's Dave Jones
@ 2012-04-20 17:03 ` Dave Jones
2012-04-20 18:11 ` Steven Rostedt
0 siblings, 1 reply; 3+ messages in thread
From: Dave Jones @ 2012-04-20 17:03 UTC (permalink / raw)
To: Linux Kernel, laijs, fweisbec, srostedt, mingo
On Wed, Apr 11, 2012 at 10:31:32PM -0400, Dave Jones wrote:
> These warnings are trivially triggerable by any user, and serve no useful purpose afaics
> Just -EINVAL and be done.
>
> Signed-off-by: Dave Jones <davej@redhat.com>
>
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index ed7b5d1..a745317 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -4136,13 +4136,11 @@ tracing_buffers_splice_read(struct file *file, loff_t *ppos,
> return -ENOMEM;
>
> if (*ppos & (PAGE_SIZE - 1)) {
> - WARN_ONCE(1, "Ftrace: previous read must page-align\n");
> ret = -EINVAL;
> goto out;
> }
>
> if (len & (PAGE_SIZE - 1)) {
> - WARN_ONCE(1, "Ftrace: splice_read should page-align\n");
> if (len < PAGE_SIZE) {
> ret = -EINVAL;
> goto out;
> --
Anyone want to pick this up, or shall I just send it to Linus myself ?
Dave
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: remove unnecessary ftrace WARN_ONCE's.
2012-04-20 17:03 ` Dave Jones
@ 2012-04-20 18:11 ` Steven Rostedt
0 siblings, 0 replies; 3+ messages in thread
From: Steven Rostedt @ 2012-04-20 18:11 UTC (permalink / raw)
To: Dave Jones; +Cc: Linux Kernel, laijs, fweisbec, mingo
On Fri, 2012-04-20 at 13:03 -0400, Dave Jones wrote:
> On Wed, Apr 11, 2012 at 10:31:32PM -0400, Dave Jones wrote:
> > These warnings are trivially triggerable by any user, and serve no useful purpose afaics
> > Just -EINVAL and be done.
> >
> > Signed-off-by: Dave Jones <davej@redhat.com>
> >
> > diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> > index ed7b5d1..a745317 100644
> > --- a/kernel/trace/trace.c
> > +++ b/kernel/trace/trace.c
> > @@ -4136,13 +4136,11 @@ tracing_buffers_splice_read(struct file *file, loff_t *ppos,
> > return -ENOMEM;
> >
> > if (*ppos & (PAGE_SIZE - 1)) {
> > - WARN_ONCE(1, "Ftrace: previous read must page-align\n");
> > ret = -EINVAL;
> > goto out;
> > }
> >
> > if (len & (PAGE_SIZE - 1)) {
> > - WARN_ONCE(1, "Ftrace: splice_read should page-align\n");
> > if (len < PAGE_SIZE) {
> > ret = -EINVAL;
> > goto out;
> > --
>
> Anyone want to pick this up, or shall I just send it to Linus myself ?
I can pick this up, if you don't mind them going in on 3.5. As they are
only WARN_ONCE errors, I don't think they are that big of a deal.
-- Steve
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-04-20 18:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-12 2:31 remove unnecessary ftrace WARN_ONCE's Dave Jones
2012-04-20 17:03 ` Dave Jones
2012-04-20 18:11 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox