From: Arun Sharma <asharma@fb.com>
To: linux-kernel@vger.kernel.org
Cc: Arun Sharma <asharma@fb.com>
Subject: [PATCH 0/4] perf: Support multiple stacks (v3)
Date: Fri, 20 Apr 2012 15:41:32 -0700 [thread overview]
Message-ID: <1334961696-19580-1-git-send-email-asharma@fb.com> (raw)
If userspace has two or more stacks and we happen to take a sample when
the stack pointer is pointing to a higher stack, we get truncated
callchains. This patch series tries to address that.
Changelog:
v3: add explicit checks to copy_from_user_nmi
v3: add explicit checks in perf_callchain_user*
v2: do this for compat32 as well
v2: improve safety checks and reduce max callchain size
Arun Sharma (4):
perf, x86: Allow multiple stacks
perf: Limit callchains to 127
perf, x86: Check if user fp is valid
x86: Check user address explicitly in copy_from_user_nmi()
arch/x86/include/asm/uaccess.h | 13 +++++++------
arch/x86/kernel/cpu/perf_event.c | 11 +++++++++--
arch/x86/lib/usercopy.c | 3 +++
include/linux/perf_event.h | 2 +-
4 files changed, 20 insertions(+), 9 deletions(-)
--
1.7.8.4
next reply other threads:[~2012-04-20 22:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-20 22:41 Arun Sharma [this message]
2012-04-20 22:41 ` [PATCH 1/4] perf, x86: Allow multiple stacks Arun Sharma
2012-05-07 23:46 ` Arun Sharma
2012-06-06 16:02 ` [tip:perf/core] perf/x86: " tip-bot for Arun Sharma
2012-04-20 22:41 ` [PATCH 2/4] perf: Limit callchains to 127 Arun Sharma
2012-06-06 16:03 ` [tip:perf/core] " tip-bot for Arun Sharma
2012-04-20 22:41 ` [PATCH 3/4] perf, x86: Check if user fp is valid Arun Sharma
2012-06-06 16:03 ` [tip:perf/core] perf/x86: " tip-bot for Arun Sharma
2012-04-20 22:41 ` [PATCH 4/4] x86: Check user address explicitly in copy_from_user_nmi() Arun Sharma
2012-06-05 16:55 ` Peter Zijlstra
2012-06-06 16:04 ` [tip:perf/core] perf/x86: " tip-bot for Arun Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334961696-19580-1-git-send-email-asharma@fb.com \
--to=asharma@fb.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox