From: yan <clouds.yan@gmail.com>
To: greg <gregkh@linuxfoundation.org>
Cc: kernel <linux-kernel@vger.kernel.org>, message <message.get@gmail.com>
Subject: [PATCH 3/4][Trivial] lib/kobject.c : Check ktype in kobject_add_internal
Date: Sat, 21 Apr 2012 17:58:31 +0800 [thread overview]
Message-ID: <1335002414.2188.27.camel@yan> (raw)
If someone calls kobject_init with null kobj_type, kobject_init can
detect it. But it does not have a return value, it just dumps stack.
In this case, a kobject_add after that will result in:
-->kobject_add_varg
-->kobject_add_internal
-->create_dir
-->sysfs_create_dir
-->sysfs_read_ns_type
-->kobj_child_ns_ops
In the end, it will call ->ktype->child_ns_type directly and we have
an oops.
Check ktype before really add a kobject.
Signed-off-by: Yan Hong <clouds.yan@gmail.com>
---
lib/kobject.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/lib/kobject.c b/lib/kobject.c
index 85d5e9b..3ba6216 100644
--- a/lib/kobject.c
+++ b/lib/kobject.c
@@ -164,6 +164,9 @@ static int kobject_add_internal(struct kobject *kobj)
if (!kobj)
return -ENOENT;
+ if (!kobj->ktype)
+ return -EINVAL;
+
if (!kobj->name || !kobj->name[0]) {
WARN(1, "kobject: (%p): attempted to be registered with empty "
"name!\n", kobj);
--
1.7.5.1
next reply other threads:[~2012-04-21 10:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-21 9:58 yan [this message]
2012-04-23 20:40 ` [PATCH 3/4][Trivial] lib/kobject.c : Check ktype in kobject_add_internal greg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1335002414.2188.27.camel@yan \
--to=clouds.yan@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=message.get@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox