From: yan <clouds.yan@gmail.com>
To: greg <gregkh@linuxfoundation.org>
Cc: kernel <linux-kernel@vger.kernel.org>, message <message.get@gmail.com>
Subject: [PATCH 4/4][Trivial] lib/kobject.c : check parameter in kobject_init_and_add
Date: Sat, 21 Apr 2012 18:17:49 +0800 [thread overview]
Message-ID: <1335003475.2188.43.camel@yan> (raw)
If user turns to the simple interface kobject_init_and_add
and gives a null kobject, kobject_init can detect it but
just dumps the stack. Then there is:
-->kobject_add_varg
-->kobject_set_name_vargs
In the end, it will reference kobj->name and we have an oops.
Check whether we have a valid kobject in kobject_init_and_add.
Signed-off-by: Yan Hong <clouds.yan@gmail.com>
---
lib/kobject.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/lib/kobject.c b/lib/kobject.c
index dd67855..bc05922 100644
--- a/lib/kobject.c
+++ b/lib/kobject.c
@@ -380,6 +380,9 @@ int kobject_init_and_add(struct kobject *kobj, struct kobj_type *ktype,
va_list args;
int retval;
+ if (!kobj)
+ return -EINVAL;
+
kobject_init(kobj, ktype);
va_start(args, fmt);
--
1.7.5.1
next reply other threads:[~2012-04-21 10:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-21 10:17 yan [this message]
2012-04-23 20:41 ` [PATCH 4/4][Trivial] lib/kobject.c : check parameter in kobject_init_and_add greg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1335003475.2188.43.camel@yan \
--to=clouds.yan@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=message.get@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox