[parent not found: <1335033199.699870@mail.sf-mail.de>]
* [PATCH 1/6] use linux/bitops.h instead of linux/log2.h to get fls()
[not found] ` <1335033199.699870@mail.sf-mail.de>
@ 2012-04-21 18:23 ` Rolf Eike Beer, eike-kernel
0 siblings, 0 replies; 5+ messages in thread
From: Rolf Eike Beer, eike-kernel @ 2012-04-21 18:23 UTC (permalink / raw)
To: linux-parisc; +Cc: linux-kernel, David Howells, Arnd Bergmann, H. Peter Anvin
Since d66acc39c7cee323733c8503b9de1821a56dff7e (bitops: Optimise get_order())
getorder.h includes log2.h to get fls() and fls64(). They are not defined in
log2.h, but in bitops.h. This works since log2.h includes bitops.h, but we
should do it properly to not get any bad surprises if log2.h changes.
Signed-off-by: Rolf Eike Beer <eike-kernel@sf-tec.de>
---
include/asm-generic/getorder.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/asm-generic/getorder.h b/include/asm-generic/getorder.h
index 65e4468..563114f 100644
--- a/include/asm-generic/getorder.h
+++ b/include/asm-generic/getorder.h
@@ -4,7 +4,7 @@
#ifndef __ASSEMBLY__
#include <linux/compiler.h>
-#include <linux/log2.h>
+#include <linux/bitops.h>
/*
* Runtime evaluation of get_order()
--
1.7.9.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 0/6] PA-RISC: fix compile
2012-04-21 17:52 ` [PATCH 0/6] PA-RISC: fix compile Rolf Eike Beer, eike-kernel
[not found] ` <1335033199.699870@mail.sf-mail.de>
@ 2012-05-01 13:28 ` Rolf Eike Beer
2012-05-10 20:49 ` [PATCH] use linux/bitops.h instead of linux/log2.h to get fls() Rolf Eike Beer
2012-05-12 9:53 ` David Howells
3 siblings, 0 replies; 5+ messages in thread
From: Rolf Eike Beer @ 2012-05-01 13:28 UTC (permalink / raw)
To: linux-parisc
Cc: linux-kernel, David Howells, Arnd Bergmann, H. Peter Anvin,
James Bottomley
[-- Attachment #1: Type: text/plain, Size: 930 bytes --]
Rolf Eike Beer wrote:
> Since d66acc39c7cee323733c8503b9de1821a56dff7e (bitops: Optimise
> get_order()) getorder.h includes log2.h which leads to an include loop on
> PA-RISC, bringing a bunch of other breakage to light. This patchset fixes
> the compilation of the current state of 3.4 on HPPA.
>
> Rolf Eike Beer (6):
> use linux/bitops.h instead of linux/log2.h to get fls()
> parisc: add missing includes in asm/spinlock.h
> parisc: add missing forward declarations in asm/hardware.h
> parisc: drop include of asm/pdc.h from asm/hardware.h
> parisc: add missing include of asm/page.h to asm/pgtable.h
> parisc: move definition of PAGE0 to asm/page.h
Ping? #4 meanwhile got an ACK from Grant, I have not received any other
comments. James, could you please take the latter 5 if you don't feel
comfortable with the first one? That one is just a cleanup and makes no
difference (yet) if things work or not.
Eike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] use linux/bitops.h instead of linux/log2.h to get fls()
2012-04-21 17:52 ` [PATCH 0/6] PA-RISC: fix compile Rolf Eike Beer, eike-kernel
[not found] ` <1335033199.699870@mail.sf-mail.de>
2012-05-01 13:28 ` [PATCH 0/6] PA-RISC: fix compile Rolf Eike Beer
@ 2012-05-10 20:49 ` Rolf Eike Beer
2012-05-12 9:53 ` David Howells
3 siblings, 0 replies; 5+ messages in thread
From: Rolf Eike Beer @ 2012-05-10 20:49 UTC (permalink / raw)
To: linux-kernel; +Cc: David Howells, Arnd Bergmann, H. Peter Anvin, torvalds
Since d66acc39c7cee323733c8503b9de1821a56dff7e (bitops: Optimise get_order())
getorder.h includes log2.h to get fls() and fls64(). They are not defined in
log2.h, but in bitops.h. This works since log2.h includes bitops.h, but we
should do it properly to not get any bad surprises if log2.h changes.
Signed-off-by: Rolf Eike Beer <eike-kernel@sf-tec.de>
---
include/asm-generic/getorder.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/asm-generic/getorder.h b/include/asm-generic/getorder.h
index 65e4468..563114f 100644
--- a/include/asm-generic/getorder.h
+++ b/include/asm-generic/getorder.h
@@ -4,7 +4,7 @@
#ifndef __ASSEMBLY__
#include <linux/compiler.h>
-#include <linux/log2.h>
+#include <linux/bitops.h>
/*
* Runtime evaluation of get_order()
--
1.7.9.2
--
To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] use linux/bitops.h instead of linux/log2.h to get fls()
2012-04-21 17:52 ` [PATCH 0/6] PA-RISC: fix compile Rolf Eike Beer, eike-kernel
` (2 preceding siblings ...)
2012-05-10 20:49 ` [PATCH] use linux/bitops.h instead of linux/log2.h to get fls() Rolf Eike Beer
@ 2012-05-12 9:53 ` David Howells
3 siblings, 0 replies; 5+ messages in thread
From: David Howells @ 2012-05-12 9:53 UTC (permalink / raw)
To: Rolf Eike Beer
Cc: dhowells, linux-kernel, Arnd Bergmann, H. Peter Anvin, torvalds
Rolf Eike Beer <eike-kernel@sf-tec.de> wrote:
> -#include <linux/log2.h>
That is still required as get_order() uses ilog2().
David
^ permalink raw reply [flat|nested] 5+ messages in thread