From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754128Ab2DWJa2 (ORCPT ); Mon, 23 Apr 2012 05:30:28 -0400 Received: from merlin.infradead.org ([205.233.59.134]:57011 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753641Ab2DWJa1 convert rfc822-to-8bit (ORCPT ); Mon, 23 Apr 2012 05:30:27 -0400 Message-ID: <1335173405.28150.102.camel@twins> Subject: Re: [PATCH 03/16] sched: SCHED_DEADLINE data structures. From: Peter Zijlstra To: Juri Lelli Cc: tglx@linutronix.de, mingo@redhat.com, rostedt@goodmis.org, cfriesen@nortel.com, oleg@redhat.com, fweisbec@gmail.com, darren@dvhart.com, johan.eker@ericsson.com, p.faure@akatech.ch, linux-kernel@vger.kernel.org, claudio@evidence.eu.com, michael@amarulasolutions.com, fchecconi@gmail.com, tommaso.cucinotta@sssup.it, nicola.manica@disi.unitn.it, luca.abeni@unitn.it, dhaval.giani@gmail.com, hgu1972@gmail.com, paulmck@linux.vnet.ibm.com, raistlin@linux.it, insop.song@ericsson.com, liming.wang@windriver.com Date: Mon, 23 Apr 2012 11:30:05 +0200 In-Reply-To: <1333696481-3433-4-git-send-email-juri.lelli@gmail.com> References: <1333696481-3433-1-git-send-email-juri.lelli@gmail.com> <1333696481-3433-4-git-send-email-juri.lelli@gmail.com> Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Mailer: Evolution 3.2.2- Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2012-04-06 at 09:14 +0200, Juri Lelli wrote: > /* > + * This function validates the new parameters of a -deadline task. > + * We ask for the deadline not being zero, and greater or equal > + * than the runtime. > + */ > +static bool > +__checkparam_dl(const struct sched_param2 *prm) > +{ > + return prm && (&prm->sched_deadline) != 0 && > + (s64)(&prm->sched_deadline - &prm->sched_runtime) >= 0; > +} Shouldn't this also include deadline == period for now?