From: Minchan Kim <minchan@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Seth Jennings <sjenning@linux.vnet.ibm.com>,
Nitin Gupta <ngupta@vflare.org>,
Dan Magenheimer <dan.magenheimer@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Minchan Kim <minchan@kernel.org>
Subject: [PATCH 6/6] zsmalloc: make zsmalloc portable
Date: Wed, 25 Apr 2012 15:23:14 +0900 [thread overview]
Message-ID: <1335334994-22138-7-git-send-email-minchan@kernel.org> (raw)
In-Reply-To: <1335334994-22138-1-git-send-email-minchan@kernel.org>
The zsmalloc uses __flush_tlb_one and set_pte.
It's very lower functions so that it makes arhcitecture dependency
so currently zsmalloc is used by only x86.
This patch changes them with map_vm_area and unmap_kernel_range so
it should work all architecture.
Signed-off-by: Minchan Kim <minchan@kernel.org>
---
drivers/staging/zsmalloc/Kconfig | 4 ----
drivers/staging/zsmalloc/zsmalloc-main.c | 27 +++++++++++++++++----------
drivers/staging/zsmalloc/zsmalloc_int.h | 1 -
3 files changed, 17 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/zsmalloc/Kconfig b/drivers/staging/zsmalloc/Kconfig
index a5ab720..9084565 100644
--- a/drivers/staging/zsmalloc/Kconfig
+++ b/drivers/staging/zsmalloc/Kconfig
@@ -1,9 +1,5 @@
config ZSMALLOC
tristate "Memory allocator for compressed pages"
- # X86 dependency is because of the use of __flush_tlb_one and set_pte
- # in zsmalloc-main.c.
- # TODO: convert these to portable functions
- depends on X86
default n
help
zsmalloc is a slab-based memory allocator designed to store
diff --git a/drivers/staging/zsmalloc/zsmalloc-main.c b/drivers/staging/zsmalloc/zsmalloc-main.c
index ff089f8..cc017b1 100644
--- a/drivers/staging/zsmalloc/zsmalloc-main.c
+++ b/drivers/staging/zsmalloc/zsmalloc-main.c
@@ -442,7 +442,7 @@ static int zs_cpu_notifier(struct notifier_block *nb, unsigned long action,
area = &per_cpu(zs_map_area, cpu);
if (area->vm)
break;
- area->vm = alloc_vm_area(2 * PAGE_SIZE, area->vm_ptes);
+ area->vm = alloc_vm_area(2 * PAGE_SIZE, NULL);
if (!area->vm)
return notifier_from_errno(-ENOMEM);
break;
@@ -696,13 +696,22 @@ void *zs_map_object(struct zs_pool *pool, void *handle)
} else {
/* this object spans two pages */
struct page *nextp;
+ struct page *pages[2];
+ struct page **page_array = &pages[0];
+ int err;
nextp = get_next_page(page);
BUG_ON(!nextp);
+ page_array[0] = page;
+ page_array[1] = nextp;
- set_pte(area->vm_ptes[0], mk_pte(page, PAGE_KERNEL));
- set_pte(area->vm_ptes[1], mk_pte(nextp, PAGE_KERNEL));
+ /*
+ * map_vm_area never fail because we already allocated
+ * pages for page table in alloc_vm_area.
+ */
+ err = map_vm_area(area->vm, PAGE_KERNEL, &page_array);
+ BUG_ON(err);
/* We pre-allocated VM area so mapping can never fail */
area->vm_addr = area->vm->addr;
@@ -730,14 +739,12 @@ void zs_unmap_object(struct zs_pool *pool, void *handle)
off = obj_idx_to_offset(page, obj_idx, class->size);
area = &__get_cpu_var(zs_map_area);
- if (off + class->size <= PAGE_SIZE) {
+ if (off + class->size <= PAGE_SIZE)
kunmap_atomic(area->vm_addr);
- } else {
- set_pte(area->vm_ptes[0], __pte(0));
- set_pte(area->vm_ptes[1], __pte(0));
- __flush_tlb_one((unsigned long)area->vm_addr);
- __flush_tlb_one((unsigned long)area->vm_addr + PAGE_SIZE);
- }
+ else
+ unmap_kernel_range((unsigned long)area->vm->addr,
+ PAGE_SIZE * 2);
+
put_cpu_var(zs_map_area);
}
EXPORT_SYMBOL_GPL(zs_unmap_object);
diff --git a/drivers/staging/zsmalloc/zsmalloc_int.h b/drivers/staging/zsmalloc/zsmalloc_int.h
index 8f9ce0c..4c11c89 100644
--- a/drivers/staging/zsmalloc/zsmalloc_int.h
+++ b/drivers/staging/zsmalloc/zsmalloc_int.h
@@ -111,7 +111,6 @@ static const int fullness_threshold_frac = 4;
struct mapping_area {
struct vm_struct *vm;
- pte_t *vm_ptes[2];
char *vm_addr;
};
--
1.7.9.5
next prev parent reply other threads:[~2012-04-25 6:22 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-25 6:23 [PATCH 0/6] zsmalloc: clean up and fix arch dependency Minchan Kim
2012-04-25 6:23 ` [PATCH 1/6] zsmalloc: use PageFlag macro instead of [set|test]_bit Minchan Kim
2012-04-25 12:43 ` Nitin Gupta
2012-04-25 6:23 ` [PATCH 2/6] zsmalloc: remove unnecessary alignment Minchan Kim
2012-04-25 12:53 ` Nitin Gupta
2012-04-26 1:42 ` Minchan Kim
2012-05-03 5:16 ` Nitin Gupta
2012-04-25 6:23 ` [PATCH 3/6] zsmalloc: rename zspage_order with zspage_pages Minchan Kim
2012-04-25 13:03 ` Nitin Gupta
2012-04-26 1:46 ` Minchan Kim
2012-04-25 6:23 ` [PATCH 4/6] zsmalloc: add/fix function comment Minchan Kim
2012-04-25 13:27 ` Nitin Gupta
2012-04-26 1:51 ` Minchan Kim
2012-04-25 6:23 ` [PATCH 5/6] zsmalloc: remove unnecessary type casting Minchan Kim
2012-04-25 13:35 ` Nitin Gupta
2012-04-25 17:56 ` Greg Kroah-Hartman
2012-04-25 18:13 ` Nitin Gupta
2012-04-26 1:58 ` Minchan Kim
2012-04-25 6:23 ` Minchan Kim [this message]
2012-04-25 14:32 ` [PATCH 6/6] zsmalloc: make zsmalloc portable Nitin Gupta
2012-04-25 15:40 ` Dan Magenheimer
2012-04-26 2:03 ` Minchan Kim
2012-04-26 5:07 ` Minchan Kim
2012-04-30 16:24 ` Seth Jennings
2012-04-25 16:37 ` Seth Jennings
2012-04-26 2:04 ` Minchan Kim
2012-05-07 15:14 ` Seth Jennings
2012-05-08 0:46 ` Minchan Kim
2012-04-26 2:11 ` Minchan Kim
2012-04-25 12:41 ` [PATCH 0/6] zsmalloc: clean up and fix arch dependency Nitin Gupta
2012-04-26 1:20 ` Minchan Kim
2012-04-25 18:14 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1335334994-22138-7-git-send-email-minchan@kernel.org \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=dan.magenheimer@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ngupta@vflare.org \
--cc=sjenning@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).