From: Peter Zijlstra <peterz@infradead.org>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu,
laijs@cn.fujitsu.com, dipankar@in.ibm.com,
akpm@linux-foundation.org, mathieu.desnoyers@polymtl.ca,
josh@joshtriplett.org, niv@us.ibm.com, tglx@linutronix.de,
rostedt@goodmis.org, Valdis.Kletnieks@vt.edu,
dhowells@redhat.com, eric.dumazet@gmail.com, darren@dvhart.com,
fweisbec@gmail.com, patches@linaro.org,
"Paul E. McKenney" <paul.mckenney@linaro.org>
Subject: Re: [PATCH RFC tip/core/rcu 4/6] rcu: Clarify help text for RCU_BOOST_PRIO
Date: Thu, 26 Apr 2012 14:46:31 +0200 [thread overview]
Message-ID: <1335444391.13683.11.camel@twins> (raw)
In-Reply-To: <1335199347-13926-4-git-send-email-paulmck@linux.vnet.ibm.com>
On Mon, 2012-04-23 at 09:42 -0700, Paul E. McKenney wrote:
> + This option specifies the real-time priority to which long-term
> + preempted RCU readers are to be boosted. If you are working
> + with a real-time application that has one or more CPU-bound
> + threads running at a real-time priority level,
Then your application is broken ;-) the kernel is known to mis-behave
under these circumstances since it doesn't get to run house-keeping
tasks. RCU is just one of these and elevating it doesn't make it work.
> you should set
> + RCU_BOOST_PRIO to a priority higher then the highest-priority
> + real-time CPU-bound thread. The default RCU_BOOST_PRIO value
> + of 1 is appropriate in the common case, which is real-time
> + applications that do not have any CPU-bound threads.
Alternatively, 1 is the worst possible choice forcing people to consider
the issue.
> + Some real-time applications might not have a single real-time
> + thread that saturates a given CPU, but instead might have
> + multiple real-time threads that, taken together, fully utilize
> + that CPU. In this case, you should set RCU_BOOST_PRIO to
> + a priority higher than the lowest-priority thread that is
> + conspiring to prevent the CPU from running any non-real-time
> + tasks. For example, if one thread at priority 10 and another
> + thread at priority 5 are between themselves fully consuming
> + the CPU time on a given CPU, then RCU_BOOST_PRIO should be
> + set to priority 6 or higher.
I'd call this misleading, who's to say that preempting the 5 would yield
enough time to complete the RCU work?
This all gets us back to the fun question of RCU delayed bandwidth
budgeting.. ideally every 'task' that does call_rcu() should donate some
of its budget towards the thread running the callback.
Anyway, I'd argue both the old and new description are bonkers.
next prev parent reply other threads:[~2012-04-26 12:47 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-23 16:41 [PATCH RFC 0/6] Miscellaneous RCU fixes for 3.5 Paul E. McKenney
2012-04-23 16:42 ` [PATCH RFC tip/core/rcu 1/6] rcu: Stabilize use of num_online_cpus() for GP short circuit Paul E. McKenney
2012-04-23 16:42 ` [PATCH RFC tip/core/rcu 2/6] rcu: List-debug variants of rcu list routines Paul E. McKenney
2012-04-23 16:42 ` [PATCH RFC tip/core/rcu 3/6] rcu: Replace list_first_entry_rcu() with list_first_or_null_rcu() Paul E. McKenney
2012-04-23 16:42 ` [PATCH RFC tip/core/rcu 4/6] rcu: Clarify help text for RCU_BOOST_PRIO Paul E. McKenney
2012-04-26 12:46 ` Peter Zijlstra [this message]
2012-04-26 17:28 ` Paul E. McKenney
2012-04-23 16:42 ` [PATCH RFC tip/core/rcu 5/6] rcu: Make __kfree_rcu() less dependent on compiler choices Paul E. McKenney
2012-04-26 12:48 ` Peter Zijlstra
2012-04-26 13:29 ` Jan Engelhardt
2012-04-26 13:50 ` Peter Zijlstra
2012-04-23 16:42 ` [PATCH RFC tip/core/rcu 6/6] rcu: Reduce cache-miss initialization latencies for large systems Paul E. McKenney
2012-04-26 12:51 ` Peter Zijlstra
2012-04-26 14:12 ` Paul E. McKenney
2012-04-26 15:28 ` Peter Zijlstra
2012-04-26 16:15 ` Paul E. McKenney
2012-04-26 19:41 ` Peter Zijlstra
2012-04-26 19:47 ` Peter Zijlstra
2012-04-26 20:29 ` Paul E. McKenney
2012-04-26 22:04 ` Peter Zijlstra
2012-04-26 20:28 ` Paul E. McKenney
2012-04-26 22:01 ` Peter Zijlstra
2012-04-27 14:17 ` Paul E. McKenney
2012-04-27 4:36 ` Mike Galbraith
2012-04-27 15:15 ` Paul E. McKenney
2012-04-28 4:42 ` Mike Galbraith
2012-04-28 17:21 ` Paul E. McKenney
2012-04-29 3:54 ` Mike Galbraith
2012-04-24 15:35 ` [PATCH RFC tip/core/rcu 1/6] rcu: Stabilize use of num_online_cpus() for GP short circuit Srivatsa S. Bhat
2012-04-24 16:50 ` Paul E. McKenney
2012-04-24 17:46 ` Srivatsa S. Bhat
2012-05-07 3:47 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1335444391.13683.11.camel@twins \
--to=peterz@infradead.org \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=darren@dvhart.com \
--cc=dhowells@redhat.com \
--cc=dipankar@in.ibm.com \
--cc=eric.dumazet@gmail.com \
--cc=fweisbec@gmail.com \
--cc=josh@joshtriplett.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mingo@elte.hu \
--cc=niv@us.ibm.com \
--cc=patches@linaro.org \
--cc=paul.mckenney@linaro.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox