From: Will Deacon <will.deacon@arm.com>
To: linux-kernel@vger.kernel.org
Cc: uclinux-dist-devel@blackfin.uclinux.org,
Will Deacon <will.deacon@arm.com>, Arnd Bergmann <arnd@arndb.de>,
Mike Frysinger <vapier@gentoo.org>
Subject: [PATCH 1/2] asm-generic: io: remove {read,write} string functions
Date: Fri, 27 Apr 2012 11:42:55 +0100 [thread overview]
Message-ID: <1335523376-14695-1-git-send-email-will.deacon@arm.com> (raw)
The {read,write}s{b,w,l} functions are not defined across all
architectures and therefore shouldn't be used by portable drivers. We
should encourage driver writers to use the io{read,write}{8,16,32}_rep
functions instead.
This patch removes the {read,write} string functions for the generic IO
header as they have no place in a new architecture port.
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Mike Frysinger <vapier@gentoo.org>
Signed-off-by: Will Deacon <will.deacon@arm.com>
---
include/asm-generic/io.h | 30 ------------------------------
1 files changed, 0 insertions(+), 30 deletions(-)
diff --git a/include/asm-generic/io.h b/include/asm-generic/io.h
index 448303b..3607921 100644
--- a/include/asm-generic/io.h
+++ b/include/asm-generic/io.h
@@ -217,36 +217,6 @@ static inline void outsl(unsigned long addr, const void *buffer, int count)
}
#endif
-static inline void readsl(const void __iomem *addr, void *buf, int len)
-{
- insl(addr - PCI_IOBASE, buf, len);
-}
-
-static inline void readsw(const void __iomem *addr, void *buf, int len)
-{
- insw(addr - PCI_IOBASE, buf, len);
-}
-
-static inline void readsb(const void __iomem *addr, void *buf, int len)
-{
- insb(addr - PCI_IOBASE, buf, len);
-}
-
-static inline void writesl(const void __iomem *addr, const void *buf, int len)
-{
- outsl(addr - PCI_IOBASE, buf, len);
-}
-
-static inline void writesw(const void __iomem *addr, const void *buf, int len)
-{
- outsw(addr - PCI_IOBASE, buf, len);
-}
-
-static inline void writesb(const void __iomem *addr, const void *buf, int len)
-{
- outsb(addr - PCI_IOBASE, buf, len);
-}
-
#ifndef CONFIG_GENERIC_IOMAP
#define ioread8(addr) readb(addr)
#define ioread16(addr) readw(addr)
--
1.7.4.1
next reply other threads:[~2012-04-27 10:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-27 10:42 Will Deacon [this message]
2012-04-27 10:42 ` [PATCH 2/2] asm-generic: io: don't perform swab during {in,out} string functions Will Deacon
2012-04-27 12:12 ` Arnd Bergmann
2012-04-27 16:18 ` Mike Frysinger
2012-04-27 16:59 ` Will Deacon
2012-04-27 17:26 ` Mike Frysinger
2012-04-27 12:12 ` [PATCH 1/2] asm-generic: io: remove {read,write} " Arnd Bergmann
2012-04-27 16:17 ` Mike Frysinger
2012-04-27 16:53 ` Will Deacon
2012-04-27 17:18 ` Mike Frysinger
2012-04-28 8:46 ` Geert Uytterhoeven
2012-04-27 20:29 ` H. Peter Anvin
2012-04-27 16:23 ` H. Peter Anvin
2012-04-27 17:14 ` Will Deacon
2012-04-27 17:53 ` H. Peter Anvin
2012-04-27 20:52 ` Arnd Bergmann
2012-04-27 23:26 ` Mike Frysinger
2012-05-01 13:34 ` Will Deacon
2012-05-01 14:40 ` Arnd Bergmann
2012-05-01 18:28 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1335523376-14695-1-git-send-email-will.deacon@arm.com \
--to=will.deacon@arm.com \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox