From: Joe Perches <joe@perches.com>
To: Eric Nelson <eric.nelson@boundarydevices.com>
Cc: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
u-boot@lists.denx.de, rylv50@freescale.com, marex@denx.de,
vapier@gentoo.org
Subject: Re: [PATCH] checkpatch: add check for whitespace before semicolon at end-of-line
Date: Thu, 03 May 2012 08:52:56 -0700 [thread overview]
Message-ID: <1336060376.13866.6.camel@joe2Laptop> (raw)
In-Reply-To: <4FA28AF4.1000205@boundarydevices.com>
On Thu, 2012-05-03 at 06:41 -0700, Eric Nelson wrote:
> >> +# check for whitespace before semicolon - not allowed at end-of-line
> >> + if ($line =~ /\s+;$/) {
> >
> > if ($line =~ /\s+;\s*$/)
> Won't the extra space at end of line be caught by other tests?
Yes it will.
You want the test to find the space before semicolon
whenever it exists.
prev parent reply other threads:[~2012-05-03 15:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <http://lists.denx.de/pipermail/u-boot/2012-May/123595.html>
2012-05-03 3:32 ` [PATCH] checkpatch: add check for whitespace before semicolon at end-of-line Eric Nelson
2012-05-03 3:58 ` Joe Perches
2012-05-03 13:41 ` Eric Nelson
2012-05-03 15:52 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336060376.13866.6.camel@joe2Laptop \
--to=joe@perches.com \
--cc=eric.nelson@boundarydevices.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=rylv50@freescale.com \
--cc=u-boot@lists.denx.de \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox