From: Jim Cromie <jim.cromie@gmail.com>
To: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Cc: jbaron@redhat.com, Jim Cromie <jim.cromie@gmail.com>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: [PATCH 1/3] params.c: fix Smack complaint about parse_args
Date: Thu, 3 May 2012 11:57:37 -0600 [thread overview]
Message-ID: <1336067860-19953-1-git-send-email-jim.cromie@gmail.com> (raw)
In commit 9fb48c744: "params: add 3rd arg to option handler callback
signature", the if-guard added to the pr_debug was overzealous; no
callers pass NULL, and existing code above and below the guard assumes
as much. Change the if-guard to match, and silence the Smack
complaint.
CC: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
kernel/params.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/params.c b/kernel/params.c
index b60e2c7..be78c90 100644
--- a/kernel/params.c
+++ b/kernel/params.c
@@ -190,7 +190,7 @@ int parse_args(const char *doing,
/* Chew leading spaces */
args = skip_spaces(args);
- if (args && *args)
+ if (*args)
pr_debug("doing %s, parsing ARGS: '%s'\n", doing, args);
while (*args) {
--
1.7.8.1
next reply other threads:[~2012-05-03 17:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-03 17:57 Jim Cromie [this message]
2012-05-03 17:57 ` [PATCH 2/3] params: replace printk(KERN_<LVL>...) with pr_<lvl>(...) Jim Cromie
2012-05-03 18:50 ` Joe Perches
2012-05-03 17:57 ` [PATCH 3/3] dynamic_debug: remove unneeded includes Jim Cromie
2012-05-05 4:36 ` Stephen Rothwell
2012-05-05 5:52 ` Jim Cromie
2012-05-05 6:08 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336067860-19953-1-git-send-email-jim.cromie@gmail.com \
--to=jim.cromie@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox