From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Diwakar Tundlam <dtundlam@nvidia.com>
Cc: "'Ingo Molnar'" <mingo@kernel.org>,
"'David Rientjes'" <rientjes@google.com>,
"'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
Peter De Schrijver <pdeschrijver@nvidia.com>
Subject: Re: [PATCH] sched: Make nr_uninterruptible count a signed value
Date: Tue, 08 May 2012 23:56:32 +0200 [thread overview]
Message-ID: <1336514192.8226.52.camel@twins> (raw)
In-Reply-To: <1DD7BFEDD3147247B1355BEFEFE46652379C3DF10C@HQMAIL04.nvidia.com>
On Tue, 2012-05-08 at 14:39 -0700, Diwakar Tundlam wrote:
> Declare nr_uninterruptible as a signed long to avoid garbage values
> seen in cat /proc/sched_debug when a task is moved to the run queue of
> a newly online core. This is part of a global counter where only the
> total sum over all CPUs matters.
Its late here, but do explain how any of this makes any difference what
so ever? Since all we do with that field is add/sub the whole sign issue
shouldn't matter one way or the other.
next prev parent reply other threads:[~2012-05-08 21:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-08 21:39 [PATCH] sched: Make nr_uninterruptible count a signed value Diwakar Tundlam
2012-05-08 21:56 ` Peter Zijlstra [this message]
2012-05-08 22:14 ` Diwakar Tundlam
2012-05-08 22:27 ` Peter Zijlstra
2012-05-08 22:29 ` Peter Zijlstra
2012-05-08 22:46 ` Diwakar Tundlam
2012-05-09 7:49 ` Michael Wang
2012-05-09 18:55 ` Diwakar Tundlam
2012-05-10 4:46 ` Michael Wang
2012-05-09 8:11 ` Peter Zijlstra
2012-05-09 19:04 ` Diwakar Tundlam
2012-05-10 3:41 ` Michael Wang
2012-05-10 9:46 ` Peter Zijlstra
2012-05-11 2:19 ` Michael Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336514192.8226.52.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=dtundlam@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pdeschrijver@nvidia.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox