From: Igor Mammedov <imammedo@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: rob@landley.net, tglx@linutronix.de, mingo@redhat.com,
hpa@zytor.com, x86@kernel.org, luto@mit.edu,
suresh.b.siddha@intel.com, avi@redhat.com, imammedo@redhat.com,
a.p.zijlstra@chello.nl, johnstul@us.ibm.com,
arjan@linux.intel.com, linux-doc@vger.kernel.org
Subject: [PATCH 4/5] Cancel secondary CPU bringup if boot cpu abandoned this effort
Date: Wed, 9 May 2012 12:25:01 +0200 [thread overview]
Message-ID: <1336559102-28103-5-git-send-email-imammedo@redhat.com> (raw)
In-Reply-To: <1336559102-28103-1-git-send-email-imammedo@redhat.com>
Instead go to idle without setting cpu online, which results in calling play_dead()
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
arch/x86/include/asm/tsc.h | 2 +-
arch/x86/kernel/smpboot.c | 12 +++++++++++-
arch/x86/kernel/tsc_sync.c | 10 ++++++----
3 files changed, 18 insertions(+), 6 deletions(-)
diff --git a/arch/x86/include/asm/tsc.h b/arch/x86/include/asm/tsc.h
index c91e8b9..b2491fc 100644
--- a/arch/x86/include/asm/tsc.h
+++ b/arch/x86/include/asm/tsc.h
@@ -58,7 +58,7 @@ extern int tsc_clocksource_reliable;
* all CPUs/cores:
*/
extern void check_tsc_sync_source(int cpu);
-extern void check_tsc_sync_target(void);
+extern bool check_tsc_sync_target(void);
extern int notsc_setup(char *);
extern void tsc_save_sched_clock_state(void);
diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index ae19d90..af63cab 100644
--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -264,7 +264,16 @@ notrace static void __cpuinit start_secondary(void *unused)
/*
* Check TSC synchronization with the BP:
*/
- check_tsc_sync_target();
+ if (!check_tsc_sync_target()) {
+ clear_local_APIC();
+
+ /* was set by cpu_init() */
+ cpumask_clear_cpu(smp_processor_id(), cpu_initialized_mask);
+ /* was set by smp_callin() */
+ cpumask_clear_cpu(smp_processor_id(), cpu_callin_mask);
+
+ goto do_idle;
+ }
notify_cpu_starting(smp_processor_id());
@@ -296,6 +305,7 @@ notrace static void __cpuinit start_secondary(void *unused)
x86_cpuinit.setup_percpu_clockev();
+do_idle:
wmb();
cpu_idle();
}
diff --git a/arch/x86/kernel/tsc_sync.c b/arch/x86/kernel/tsc_sync.c
index 1741385..45a593e 100644
--- a/arch/x86/kernel/tsc_sync.c
+++ b/arch/x86/kernel/tsc_sync.c
@@ -180,22 +180,22 @@ void __cpuinit check_tsc_sync_source(int cpu)
/*
* Freshly booted CPUs call into this:
*/
-void __cpuinit check_tsc_sync_target(void)
+bool __cpuinit check_tsc_sync_target(void)
{
if (unsynchronized_tsc() || tsc_clocksource_reliable)
- return;
+ return true;
/*
* Wait for the source CPU to start the measurement
*/
while (!atomic_read(&start_tsc_sync)) {
if (!cpumask_test_cpu(smp_processor_id(), cpu_callout_mask))
- return;
+ return false;
cpu_relax();
}
if (!cpumask_test_cpu(smp_processor_id(), cpu_callout_mask))
- return;
+ return false;
atomic_set(&start_tsc_sync, 0);
@@ -211,4 +211,6 @@ void __cpuinit check_tsc_sync_target(void)
*/
while (atomic_read(&stop_tsc_sync))
cpu_relax();
+
+ return true;
}
--
1.7.1
next prev parent reply other threads:[~2012-05-09 8:27 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-09 10:24 [PATCH 0/5] [x86]: Improve secondary CPU bring-up process robustness Igor Mammedov
2012-05-09 9:19 ` Peter Zijlstra
2012-05-09 12:29 ` Igor Mammedov
2012-05-09 13:12 ` Ingo Molnar
2012-05-10 17:31 ` Rob Landley
2012-05-10 17:39 ` Peter Zijlstra
2012-05-09 10:24 ` [PATCH 1/5] Fix soft-lookup in stop machine on secondary cpu bring up Igor Mammedov
2012-05-09 15:04 ` Shuah Khan
2012-05-09 15:22 ` Igor Mammedov
2012-05-09 15:34 ` Shuah Khan
2012-05-10 15:26 ` Shuah Khan
2012-05-10 16:29 ` Igor Mammedov
2012-05-10 16:38 ` Shuah Khan
2012-05-11 11:45 ` Thomas Gleixner
2012-05-11 15:16 ` Igor Mammedov
2012-05-11 21:14 ` Thomas Gleixner
2012-05-12 19:32 ` [RFC] [x86]: abort secondary cpu bringup gracefully Igor Mammedov
2012-05-12 17:39 ` Peter Zijlstra
2012-05-12 18:51 ` Igor Mammedov
2012-05-14 11:09 ` [RFC v2] " Igor Mammedov
2012-05-24 15:41 ` Igor Mammedov
2012-05-25 18:11 ` Rob Landley
2012-05-30 16:38 ` Igor Mammedov
2012-05-09 10:24 ` [PATCH 2/5] Take in account that several cpus might call check_tsc_sync_* at the same time Igor Mammedov
2012-05-09 10:25 ` [PATCH 3/5] Do not wait till next cpu online and abort early if lead cpu do not wait for us anymore Igor Mammedov
2012-05-09 10:25 ` Igor Mammedov [this message]
2012-05-09 10:25 ` [PATCH 5/5] Do not mark cpu as not present if we failed to boot it Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336559102-28103-5-git-send-email-imammedo@redhat.com \
--to=imammedo@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=arjan@linux.intel.com \
--cc=avi@redhat.com \
--cc=hpa@zytor.com \
--cc=johnstul@us.ibm.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@mit.edu \
--cc=mingo@redhat.com \
--cc=rob@landley.net \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).