Re: [PATCH 1/1] USB: serial: Whitespace and formatting to conform with checkpatch.sh script

Greg KH
2012-05-09T21:44:44Z

On Wed, May 09, 2012 at 11:11:50PM +1000, Ben Minerds wrote:
> Removed 19 errors and 53 warnings (space before tabs, spaces required
> around '?' ':' '=', space prohibited '(', trailing whitespace, not a
> function, and parentheses are not required).

That's nice, but please don't do this all in one patch. Please do one
thing per patch (i.e. get rid of one type of warning or error per patch)

That way we can review it easier, and it can be applied easier. As it
is, this patch doesn't apply to my usb-next branch due to other patches
in there already for this file that conflict with it.

Care to redo it and break it up and resend it?

thanks,

greg k-h