[PATCH] block: remove some unnecessary codes

[PATCH] block: remove some unnecessary codes

[zwu.kernel]

From: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>

Signed-off-by: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
---
 block/partition-generic.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/block/partition-generic.c b/block/partition-generic.c
index 6df5d69..4c03880 100644
--- a/block/partition-generic.c
+++ b/block/partition-generic.c
@@ -473,7 +473,6 @@ rescan:
 	/* add partitions */
 	for (p = 1; p < state->limit; p++) {
 		sector_t size, from;
-		struct partition_meta_info *info = NULL;
 
 		size = state->parts[p].size;
 		if (!size)
@@ -509,7 +508,6 @@ rescan:
 		}
 
 		if (state->parts[p].has_info)
-			info = &state->parts[p].info;
 		part = add_partition(disk, p, from, size,
 				     state->parts[p].flags,
 				     &state->parts[p].info);
-- 
1.7.6

Re: [PATCH] block: remove some unnecessary codes

[Thiago Rafel Becker]

You should also remove the if statement on line 511.

On Thu, 10 May 2012, zwu.kernel@gmail.com wrote:

> From: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
>
> Signed-off-by: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
> ---
>  block/partition-generic.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/block/partition-generic.c b/block/partition-generic.c
> index 6df5d69..4c03880 100644
> --- a/block/partition-generic.c
> +++ b/block/partition-generic.c
> @@ -473,7 +473,6 @@ rescan:
>  	/* add partitions */
>  	for (p = 1; p < state->limit; p++) {
>  		sector_t size, from;
> -		struct partition_meta_info *info = NULL;
>
>  		size = state->parts[p].size;
>  		if (!size)
> @@ -509,7 +508,6 @@ rescan:
>  		}
>
>  		if (state->parts[p].has_info)
> -			info = &state->parts[p].info;
>  		part = add_partition(disk, p, from, size,
>  				     state->parts[p].flags,
>  				     &state->parts[p].info);
> --
> 1.7.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

Re: [PATCH] block: remove some unnecessary codes

[Zhi Yong Wu]

On Thu, May 10, 2012 at 10:58 AM, Thiago Rafel Becker
<trbecker@trbecker.org> wrote:
> You should also remove the if statement on line 511.
Yeah, good comment. thanks. pls see v2.
>
> On Thu, 10 May 2012, zwu.kernel@gmail.com wrote:
>
>> From: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
>>
>> Signed-off-by: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
>> ---
>>  block/partition-generic.c |    2 --
>>  1 files changed, 0 insertions(+), 2 deletions(-)
>>
>> diff --git a/block/partition-generic.c b/block/partition-generic.c
>> index 6df5d69..4c03880 100644
>> --- a/block/partition-generic.c
>> +++ b/block/partition-generic.c
>> @@ -473,7 +473,6 @@ rescan:
>>       /* add partitions */
>>       for (p = 1; p < state->limit; p++) {
>>               sector_t size, from;
>> -             struct partition_meta_info *info = NULL;
>>
>>               size = state->parts[p].size;
>>               if (!size)
>> @@ -509,7 +508,6 @@ rescan:
>>               }
>>
>>               if (state->parts[p].has_info)
>> -                     info = &state->parts[p].info;
>>               part = add_partition(disk, p, from, size,
>>                                    state->parts[p].flags,
>>                                    &state->parts[p].info);
>> --
>> 1.7.6
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at  http://www.tux.org/lkml/
>>



-- 
Regards,

Zhi Yong Wu