linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alex Shi <alex.shi@intel.com>
To: rob@landley.net, tglx@linutronix.de, mingo@redhat.com,
	hpa@zytor.com, arnd@arndb.de, rostedt@goodmis.org,
	fweisbec@gmail.com
Cc: jeremy@goop.org, gregkh@linuxfoundation.org,
	borislav.petkov@amd.com, alex.shi@intel.com, riel@redhat.com,
	luto@mit.edu, avi@redhat.com, len.brown@intel.com,
	dhowells@redhat.com, fenghua.yu@intel.com, ak@linux.intel.com,
	cpw@sgi.com, steiner@sgi.com, akpm@linux-foundation.org,
	penberg@kernel.org, hughd@google.com, rientjes@google.com,
	kosaki.motohiro@jp.fujitsu.com, n-horiguchi@ah.jp.nec.com,
	paul.gortmaker@windriver.com, trenn@suse.de, tj@kernel.org,
	oleg@redhat.com, axboe@kernel.dk, a.p.zijlstra@chello.nl,
	kamezawa.hiroyu@jp.fujitsu.com, viro@zeniv.linux.org.uk,
	linux-kernel@vger.kernel.org
Subject: [PATCH v4 7/7] x86/tlb: add tlb_flushall_factor into sysfs for user testing/tuning
Date: Thu, 10 May 2012 13:00:13 +0800	[thread overview]
Message-ID: <1336626013-28413-8-git-send-email-alex.shi@intel.com> (raw)
In-Reply-To: <1336626013-28413-1-git-send-email-alex.shi@intel.com>

kernel will replace cr3 rewrite with invlpg when
  tlb_flush_entries <= active_tlb_entries / 2^tlb_flushall_factor
if tlb_flushall_factor is -1, kernel won't do this replacement.

User can modify its value according to specific applications.

Signed-off-by: Alex Shi <alex.shi@intel.com>
---
 Documentation/ABI/testing/sysfs-devices-system-cpu |   12 ++++++
 arch/x86/Kconfig.debug                             |   11 ++++++
 arch/x86/kernel/cpu/common.c                       |   37 ++++++++++++++++++++
 drivers/base/cpu.c                                 |    4 ++
 include/linux/cpu.h                                |    4 ++
 5 files changed, 68 insertions(+), 0 deletions(-)

diff --git a/Documentation/ABI/testing/sysfs-devices-system-cpu b/Documentation/ABI/testing/sysfs-devices-system-cpu
index e7be75b..05f8eb7 100644
--- a/Documentation/ABI/testing/sysfs-devices-system-cpu
+++ b/Documentation/ABI/testing/sysfs-devices-system-cpu
@@ -78,6 +78,18 @@ Description:	Dynamic addition and removal of CPU's.  This is not hotplug
 		the system.  Information writtento the file to remove CPU's
 		is architecture specific.
 
+What:		/sys/devices/system/cpu/tlb_flushall_factor
+Date:		May 2012
+Contact:	Linux kernel mailing list <linux-kernel@vger.kernel.org>
+Description:	tlb_flushall_factor show and setting interface
+		tlb_flushall_factor shows the balance point in replacing cr3
+		writting with multiple 'invlpg'. It will do this replacement
+		when flush_tlb_lines <= active_lines/2^tlb_flushall_factor
+		If tlb_flushall_factor is -1, means the replacement will be
+		disabled.
+
+		User can set this for the specific CPU or application.
+
 What:		/sys/devices/system/cpu/cpu#/node
 Date:		October 2009
 Contact:	Linux memory management mailing list <linux-mm@kvack.org>
diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug
index e46c214..5b87493 100644
--- a/arch/x86/Kconfig.debug
+++ b/arch/x86/Kconfig.debug
@@ -129,6 +129,17 @@ config DOUBLEFAULT
 	  option saves about 4k and might cause you much additional grey
 	  hair.
 
+config DEBUG_TLBFLUSH
+	bool "Enable user level tlb flush all setting"
+	depends on DEBUG_KERNEL && (X86_64 || X86_INVLPG)
+	---help---
+	  This option allows user tune tlb_flushall_factor knob that under
+	  /sys/devices/system/cpu, set to -1 means do tlb flush all for any
+	  multiple tlb lines evacuation demand. Otherwise kernel will use
+	  multiple 'invlpg' for the demand when
+	      flush_lines <= active_tlb_lines / 2^tlb_flushall_factor
+	  If in doubt, say "N"
+
 config IOMMU_DEBUG
 	bool "Enable IOMMU debugging"
 	depends on GART_IOMMU && DEBUG_KERNEL
diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
index 8879d20..d1986c6 100644
--- a/arch/x86/kernel/cpu/common.c
+++ b/arch/x86/kernel/cpu/common.c
@@ -481,6 +481,43 @@ void __cpuinit cpu_detect_tlb(struct cpuinfo_x86 *c)
 		tlb_flushall_factor);
 }
 
+#ifdef CONFIG_DEBUG_TLBFLUSH
+static ssize_t __tlb_flushall_factor_store(const char *buf,
+					size_t count, int smt)
+{
+	short factor = 0;
+
+	if (sscanf(buf, "%hd", &factor) != 1)
+		return -EINVAL;
+
+	tlb_flushall_factor = factor;
+
+	return count;
+}
+
+static ssize_t tlb_flushall_factor_show(struct device *dev,
+					   struct device_attribute *attr,
+					   char *buf)
+{
+	return sprintf(buf, "%hd\n", tlb_flushall_factor);
+}
+static ssize_t tlb_flushall_factor_store(struct device *dev,
+					    struct device_attribute *attr,
+					    const char *buf, size_t count)
+{
+	return __tlb_flushall_factor_store(buf, count, 0);
+}
+
+static DEVICE_ATTR(tlb_flushall_factor, 0644,
+		   tlb_flushall_factor_show,
+		   tlb_flushall_factor_store);
+
+int __init create_sysfs_tlb_flushall_factor(struct device *dev)
+{
+	return device_create_file(dev, &dev_attr_tlb_flushall_factor);
+}
+#endif
+
 void __cpuinit detect_ht(struct cpuinfo_x86 *c)
 {
 #ifdef CONFIG_X86_HT
diff --git a/drivers/base/cpu.c b/drivers/base/cpu.c
index adf937b..dc0f77b 100644
--- a/drivers/base/cpu.c
+++ b/drivers/base/cpu.c
@@ -331,6 +331,10 @@ void __init cpu_dev_init(void)
 
 	cpu_dev_register_generic();
 
+#ifdef CONFIG_DEBUG_TLBFLUSH
+	create_sysfs_tlb_flushall_factor(cpu_subsys.dev_root);
+#endif
+
 #if defined(CONFIG_SCHED_MC) || defined(CONFIG_SCHED_SMT)
 	sched_create_sysfs_power_savings_entries(cpu_subsys.dev_root);
 #endif
diff --git a/include/linux/cpu.h b/include/linux/cpu.h
index ee28844..3eb85a5 100644
--- a/include/linux/cpu.h
+++ b/include/linux/cpu.h
@@ -36,6 +36,10 @@ extern void cpu_remove_dev_attr(struct device_attribute *attr);
 extern int cpu_add_dev_attr_group(struct attribute_group *attrs);
 extern void cpu_remove_dev_attr_group(struct attribute_group *attrs);
 
+#ifdef CONFIG_DEBUG_TLBFLUSH
+extern int create_sysfs_tlb_flushall_factor(struct device *dev);
+#endif
+
 extern int sched_create_sysfs_power_savings_entries(struct device *dev);
 
 #ifdef CONFIG_HOTPLUG_CPU
-- 
1.7.5.4


  parent reply	other threads:[~2012-05-10  5:03 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-10  5:00 [PATCH v4 0/7] tlb flush optimization Alex Shi
2012-05-10  5:00 ` [PATCH v4 1/7] x86/tlb: unify TLB_FLUSH_ALL definition Alex Shi
2012-05-10 18:46   ` Rob Landley
2012-05-11 18:33     ` H. Peter Anvin
2012-05-10  5:00 ` [PATCH v4 2/7] x86/tlb_info: get last level TLB entry number of CPU Alex Shi
2012-05-10 14:43   ` Borislav Petkov
2012-05-11  0:33     ` Alex Shi
2012-05-10 15:58   ` Borislav Petkov
2012-05-11  0:38     ` Alex Shi
2012-05-10  5:00 ` [PATCH v4 3/7] x86/flush_tlb: try flush_tlb_single one by one in flush_tlb_range Alex Shi
2012-05-10  7:53   ` Borislav Petkov
2012-05-10  8:50     ` Alex Shi
2012-05-10 21:42       ` Rob Landley
2012-05-10  8:42   ` Borislav Petkov
2012-05-10  9:04     ` Alex Shi
2012-05-12  8:01       ` Alex Shi
2012-05-13 11:13         ` Borislav Petkov
2012-05-15  1:06           ` Alex Shi
2012-05-15 10:33             ` Borislav Petkov
2012-05-15 11:16               ` Peter Zijlstra
2012-05-15 11:56                 ` Borislav Petkov
2012-05-15 12:00                   ` Peter Zijlstra
2012-05-15 13:58                     ` Alex Shi
2012-05-10  5:00 ` [PATCH v4 4/7] x86/tlb: fall back to flush all when meet a THP large page Alex Shi
2012-05-10  9:29   ` Peter Zijlstra
2012-05-10 10:40     ` Borislav Petkov
2012-05-11  0:44       ` Alex Shi
2012-05-11  9:03         ` Peter Zijlstra
2012-05-11 16:28   ` Andrea Arcangeli
2012-05-12  7:58     ` Alex Shi
2012-05-10  5:00 ` [PATCH v4 5/7] x86/tlb: add tlb flush all factor for specific CPU Alex Shi
2012-05-10  9:35   ` Peter Zijlstra
2012-05-11  0:47     ` Alex Shi
2012-05-10  9:37   ` Peter Zijlstra
2012-05-11  0:48     ` Alex Shi
2012-05-10  9:38   ` Peter Zijlstra
2012-05-10 10:42     ` Borislav Petkov
2012-05-11  0:50       ` Alex Shi
2012-05-11  0:49     ` Alex Shi
2012-05-11  9:04       ` Peter Zijlstra
2012-05-11  9:04         ` Peter Zijlstra
2012-05-11 12:51           ` Alex Shi
2012-05-10  5:00 ` [PATCH v4 6/7] x86/tlb: optimizing flush_tlb_mm Alex Shi
2012-05-10  8:27   ` Peter Zijlstra
2012-05-10  5:00 ` Alex Shi [this message]
2012-05-10  8:27   ` [PATCH v4 7/7] x86/tlb: add tlb_flushall_factor into sysfs for user testing/tuning Borislav Petkov
2012-05-11  0:52     ` Alex Shi
2012-05-11  9:51       ` Borislav Petkov
2012-05-11 12:53         ` Alex Shi
2012-05-10 15:13   ` Greg KH
2012-05-11  0:59     ` Alex Shi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1336626013-28413-8-git-send-email-alex.shi@intel.com \
    --to=alex.shi@intel.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=ak@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=avi@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=borislav.petkov@amd.com \
    --cc=cpw@sgi.com \
    --cc=dhowells@redhat.com \
    --cc=fenghua.yu@intel.com \
    --cc=fweisbec@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpa@zytor.com \
    --cc=hughd@google.com \
    --cc=jeremy@goop.org \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@mit.edu \
    --cc=mingo@redhat.com \
    --cc=n-horiguchi@ah.jp.nec.com \
    --cc=oleg@redhat.com \
    --cc=paul.gortmaker@windriver.com \
    --cc=penberg@kernel.org \
    --cc=riel@redhat.com \
    --cc=rientjes@google.com \
    --cc=rob@landley.net \
    --cc=rostedt@goodmis.org \
    --cc=steiner@sgi.com \
    --cc=tglx@linutronix.de \
    --cc=tj@kernel.org \
    --cc=trenn@suse.de \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).