From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Konstantin Khlebnikov <khlebnikov@openvz.org>
Cc: Ingo Molnar <mingo@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] sched: set TAINT_UNSAFE_SMP after sleep-in-atomic bug
Date: Thu, 10 May 2012 13:46:38 +0200 [thread overview]
Message-ID: <1336650398.27020.91.camel@laptop> (raw)
In-Reply-To: <4FAB9EC0.8090905@openvz.org>
On Thu, 2012-05-10 at 14:56 +0400, Konstantin Khlebnikov wrote:
> Peter Zijlstra wrote:
> > On Thu, 2012-05-10 at 11:54 +0400, Konstantin Khlebnikov wrote:
> >> Usually sleep-in-atomic bugs are followed by dozens other warnings.
> >> This patch should help to figure out original source of problem.
> >> This taint flag also turns off lockdep, because it can go mad after that.
> >
> > There's already TAINT_WARN any output with that set should be ignored.
>
> Where? I do not see here anything which might set TAINT_WARN.
>
> Or you suggest to use TAINT_WARN instead of TAINT_UNSAFE_SMP?
Gargh, yeah it doesn't use WARN and related infrastructure to print that
msg so it missed out on the whole TAINT_WARN stuff.
Yeah, make it set TAINT_WARN or possibly convert the thing to use WARN.
next prev parent reply other threads:[~2012-05-10 12:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-10 7:54 [PATCH] sched: set TAINT_UNSAFE_SMP after sleep-in-atomic bug Konstantin Khlebnikov
2012-05-10 10:01 ` Peter Zijlstra
2012-05-10 10:56 ` Konstantin Khlebnikov
2012-05-10 11:46 ` Peter Zijlstra [this message]
2012-05-10 12:20 ` [PATCH v2] sched: taint kernel with TAINT_WARN " Konstantin Khlebnikov
2012-05-18 8:54 ` Peter Zijlstra
2012-05-18 11:16 ` [tip:sched/core] sched: Taint " tip-bot for Konstantin Khlebnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336650398.27020.91.camel@laptop \
--to=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=khlebnikov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox