From: Peter Zijlstra <peterz@infradead.org>
To: Yinghai Lu <yinghai@kernel.org>
Cc: mingo@kernel.org, hpa@zytor.com, linux-kernel@vger.kernel.org,
tj@kernel.org, tglx@linutronix.de,
linux-tip-commits@vger.kernel.org
Subject: Re: [tip:sched/core] x86/numa: Check for nonsensical topologies on real hw as well
Date: Thu, 10 May 2012 14:08:24 +0200 [thread overview]
Message-ID: <1336651704.27020.100.camel@laptop> (raw)
In-Reply-To: <1336650578.27020.94.camel@laptop>
On Thu, 2012-05-10 at 13:49 +0200, Peter Zijlstra wrote:
> +static bool __cpuinit match_mc(struct cpuinfo_x86 *c, struct cpuinfo_x86 *o)
> +{
> + if (!topology_sane(c->cpu_index, o->cpu_index, "mc"))
> + return false;
> +
> + if (c->phys_proc_id == cpu_data(i).phys_proc_id)
> + return true;
> +
> + return false;
> +}
Argh, that has the very same problem.. it (and the same for the other
two match funcions).
Something like:
if (c->phys_proc_id == cpu_data(i).phys_proc_id && topology_sane())
might do, since then we only verify the topology after we would
otherwise have already accepted it.
next prev parent reply other threads:[~2012-05-10 12:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-09 12:59 [tip:sched/core] x86/numa: Check for nonsensical topologies on real hw as well tip-bot for Ingo Molnar
2012-05-09 22:48 ` Yinghai Lu
2012-05-10 11:49 ` Peter Zijlstra
2012-05-10 12:08 ` Peter Zijlstra [this message]
2012-05-10 13:54 ` Peter Zijlstra
2012-05-10 17:15 ` Yinghai Lu
2012-05-11 11:00 ` Sasha Levin
2012-05-11 11:11 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336651704.27020.100.camel@laptop \
--to=peterz@infradead.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox