public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Igor Mammedov <imammedo@redhat.com>
Cc: Jiang Liu <liuj97@gmail.com>,
	linux-kernel@vger.kernel.org, mingo@kernel.org, pjt@google.com,
	tglx@linutronix.de, seto.hidetoshi@jp.fujitsu.com
Subject: Re: [PATCH] sched_groups are expected to be circular linked list, make it so right after allocation
Date: Thu, 10 May 2012 15:45:44 +0200	[thread overview]
Message-ID: <1336657544.2527.116.camel@twins> (raw)
In-Reply-To: <20120510132625.GA1455@thinkpad.mammed.net>

On Thu, 2012-05-10 at 15:26 +0200, Igor Mammedov wrote:
> [  141.699854] sched: Bonkers domain doesn't include its own cpu: 3 0-1,3
> [  141.725038] sched: Bonkers domain doesn't include its own cpu: 3 0-1 

Whee!! so cpu_mask (active_mask) does include 3, but the tl->mask()
doesn't.

> [  141.775040] sched: Topology is hosed for CPU-3!!
> [  141.775596] sched: domain: NODE 0-1
> [  141.776004] sched:  group: 0-1
> 
This seems to suggest its the node topology being wrecked.

which with your code-base would be
cpu_node_mask()->sched_domain_node_span()..

Did you specify any node topology on the qemu command line? If not, it
should all reduce to cpumask_of_node(0).

identify_secondary_cpu()->identify_cpu()->numa_add_cpu() should set that
bit. which is well before the CPU_ONLINE->cpuset_update_active_cpus()
sched domain rebuild.


Most puzzling. Can you dig a little deeper as to why these masks might
be wrong? Also, can you reproduce on actual hardware? The reason I never
use kvm or other virt for debugging is that I always end up spending
time chasing virt bugs, and I hate virt..

  reply	other threads:[~2012-05-10 13:46 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-09 10:38 [PATCH] sched_groups are expected to be circular linked list, make it so right after allocation Igor Mammedov
2012-05-09 10:21 ` Jiang Liu
2012-05-09 11:44   ` Igor Mammedov
2012-05-09 11:52     ` Peter Zijlstra
2012-05-09 11:58       ` Igor Mammedov
2012-05-09 12:21         ` Peter Zijlstra
2012-05-09 12:22           ` Peter Zijlstra
2012-05-09 12:35             ` Igor Mammedov
2012-05-09 12:30           ` Peter Zijlstra
2012-05-09 13:27             ` [RFC][PATCH] printk: Add %pb to print bitmaps Peter Zijlstra
2012-05-09 13:29               ` Peter Zijlstra
2012-05-09 13:36               ` Ingo Molnar
2012-05-09 13:44                 ` Peter Zijlstra
2012-05-09 13:59                   ` Peter Zijlstra
2012-05-09 14:15                     ` Ingo Molnar
2012-05-09 14:24                       ` Peter Zijlstra
2012-05-09 15:32                       ` Peter Zijlstra
2012-05-09 15:41                         ` Ingo Molnar
2012-05-09 16:06                           ` Peter Zijlstra
2012-05-09 16:39                             ` Joe Perches
2012-05-09 17:22                               ` Ingo Molnar
2012-05-09 17:24                             ` Ingo Molnar
2012-05-09 17:25                               ` Peter Zijlstra
2012-05-09 17:31                                 ` Ingo Molnar
2012-05-09 14:19                     ` Joe Perches
2012-05-09 15:34                       ` Ingo Molnar
2012-05-09 17:15               ` Linus Torvalds
2012-05-09 17:22                 ` Peter Zijlstra
2012-05-09 17:26                   ` Ingo Molnar
2012-05-09 17:30                     ` Peter Zijlstra
2012-05-09 19:07               ` Andrew Morton
2012-05-09 20:58                 ` Peter Zijlstra
2012-05-10  7:45                   ` Ingo Molnar
2012-05-10 13:26             ` [PATCH] sched_groups are expected to be circular linked list, make it so right after allocation Igor Mammedov
2012-05-10 13:45               ` Peter Zijlstra [this message]
2012-05-10 17:01                 ` Igor Mammedov
2012-05-10 17:33                   ` Peter Zijlstra
2012-05-09 10:35 ` [tip:sched/urgent] sched: Fix KVM and ia64 boot crash due to sched_groups circular linked list assumption tip-bot for Igor Mammedov
2012-05-09 11:41 ` [PATCH] sched_groups are expected to be circular linked list, make it so right after allocation Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1336657544.2527.116.camel@twins \
    --to=peterz@infradead.org \
    --cc=imammedo@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liuj97@gmail.com \
    --cc=mingo@kernel.org \
    --cc=pjt@google.com \
    --cc=seto.hidetoshi@jp.fujitsu.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox