linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] frv: delete incorrect task prototypes causing compile fail
@ 2012-05-11 19:58 Paul Gortmaker
  0 siblings, 0 replies; only message in thread
From: Paul Gortmaker @ 2012-05-11 19:58 UTC (permalink / raw)
  To: linux-kernel; +Cc: Paul Gortmaker, David Howells, Thomas Gleixner

Commit 41101809a865dd0be1b56eff46c83fad321870b2

    "fork: Provide weak arch_release_[task_struct|thread_info] functions"

highlights a problem in the frv arch, where it has needles prototypes
for alloc_task_struct_node and free_task_struct.  This now shows up as:

kernel/fork.c:120:66: error: static declaration of 'alloc_task_struct_node' follows non-static declaration
kernel/fork.c:127:51: error: static declaration of 'free_task_struct' follows non-static declaration

since 4110180 turned them into real functions.  Since the arch/frv
does does not define define __HAVE_ARCH_TASK_STRUCT_ALLOCATOR (i.e. it
just uses the generic ones) it shouldn't list these at all.

Cc: David Howells <dhowells@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

diff --git a/arch/frv/include/asm/processor.h b/arch/frv/include/asm/processor.h
index 81c2e27..9b1a92b 100644
--- a/arch/frv/include/asm/processor.h
+++ b/arch/frv/include/asm/processor.h
@@ -135,10 +135,6 @@ unsigned long get_wchan(struct task_struct *p);
 #define	KSTK_EIP(tsk)	((tsk)->thread.frame0->pc)
 #define	KSTK_ESP(tsk)	((tsk)->thread.frame0->sp)
 
-/* Allocation and freeing of basic task resources. */
-extern struct task_struct *alloc_task_struct_node(int node);
-extern void free_task_struct(struct task_struct *p);
-
 #define cpu_relax()    barrier()
 
 /* data cache prefetch */
-- 
1.7.9.1


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2012-05-11 19:58 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-11 19:58 [PATCH] frv: delete incorrect task prototypes causing compile fail Paul Gortmaker

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).