* [PATCH] unmapped quotes
@ 2012-05-12 8:47 liwp.linux
2012-05-12 9:02 ` Michael Tokarev
0 siblings, 1 reply; 6+ messages in thread
From: liwp.linux @ 2012-05-12 8:47 UTC (permalink / raw)
To: Fengguang Wu, Jan Kara, Andrew Morton, Peter Zijlstra,
Johannes Weiner, linux-kernel
Cc: liwp.linux, Wanpeng Li
From: Wanpeng Li <liwp.linux@gmail.com>
Signed-off-by: Wanpeng Li <liwp@linux.vnet.ibm.com>
---
mm/page-writeback.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index 26adea8..2b317a3 100644
--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -1155,7 +1155,7 @@ static long bdi_min_pause(struct backing_dev_info *bdi,
* balance_dirty_pages() must be called by processes which are generating dirty
* data. It looks at the number of dirty pages in the machine and will force
* the caller to wait once crossing the (background_thresh + dirty_thresh) / 2.
- * If we're over `background_thresh' then the writeback threads are woken to
+ * If we're over 'background_thresh' then the writeback threads are woken to
* perform some writeout.
*/
static void balance_dirty_pages(struct address_space *mapping,
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] unmapped quotes
2012-05-12 8:47 [PATCH] unmapped quotes liwp.linux
@ 2012-05-12 9:02 ` Michael Tokarev
2012-05-12 11:26 ` Fengguang Wu
0 siblings, 1 reply; 6+ messages in thread
From: Michael Tokarev @ 2012-05-12 9:02 UTC (permalink / raw)
To: liwp.linux
Cc: Fengguang Wu, Jan Kara, Andrew Morton, Peter Zijlstra,
Johannes Weiner, linux-kernel, Wanpeng Li
On 12.05.2012 12:47, liwp.linux@gmail.com wrote:
> - * If we're over `background_thresh' then the writeback threads are woken to
> + * If we're over 'background_thresh' then the writeback threads are woken to
I can't say the original is wrong. Since these quotes don't have
"open" and "close" versions like {} or () pairs does, people often
use ` as opening and ' as closing - while staying within ascii.
Alternatives are things like « » or other things, but these aren't
ascii anymore. So I'd say keep it alone... ;)
/mjt
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] unmapped quotes
2012-05-12 9:02 ` Michael Tokarev
@ 2012-05-12 11:26 ` Fengguang Wu
2012-05-12 14:09 ` Johannes Weiner
2012-05-12 14:32 ` Bernd Petrovitsch
0 siblings, 2 replies; 6+ messages in thread
From: Fengguang Wu @ 2012-05-12 11:26 UTC (permalink / raw)
To: Michael Tokarev
Cc: liwp.linux, Jan Kara, Andrew Morton, Peter Zijlstra,
Johannes Weiner, linux-kernel, Wanpeng Li
On Sat, May 12, 2012 at 01:02:36PM +0400, Michael Tokarev wrote:
> On 12.05.2012 12:47, liwp.linux@gmail.com wrote:
> > - * If we're over `background_thresh' then the writeback threads are woken to
> > + * If we're over 'background_thresh' then the writeback threads are woken to
>
> I can't say the original is wrong. Since these quotes don't have
> "open" and "close" versions like {} or () pairs does, people often
> use ` as opening and ' as closing - while staying within ascii.
> Alternatives are things like « » or other things, but these aren't
> ascii anymore. So I'd say keep it alone... ;)
Agreed. For example, latex uses ` and ' as opening and closing pairs.
That does look a bit weird for C and shell users ;)
Thanks,
Fengguang
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] unmapped quotes
2012-05-12 11:26 ` Fengguang Wu
@ 2012-05-12 14:09 ` Johannes Weiner
2012-05-13 2:18 ` Cong Wang
2012-05-12 14:32 ` Bernd Petrovitsch
1 sibling, 1 reply; 6+ messages in thread
From: Johannes Weiner @ 2012-05-12 14:09 UTC (permalink / raw)
To: Fengguang Wu
Cc: Michael Tokarev, liwp.linux, Jan Kara, Andrew Morton,
Peter Zijlstra, linux-kernel, Wanpeng Li
On Sat, May 12, 2012 at 07:26:37PM +0800, Fengguang Wu wrote:
> On Sat, May 12, 2012 at 01:02:36PM +0400, Michael Tokarev wrote:
> > On 12.05.2012 12:47, liwp.linux@gmail.com wrote:
> > > - * If we're over `background_thresh' then the writeback threads are woken to
> > > + * If we're over 'background_thresh' then the writeback threads are woken to
> >
> > I can't say the original is wrong. Since these quotes don't have
> > "open" and "close" versions like {} or () pairs does, people often
> > use ` as opening and ' as closing - while staying within ascii.
> > Alternatives are things like « » or other things, but these aren't
> > ascii anymore. So I'd say keep it alone... ;)
>
> Agreed. For example, latex uses ` and ' as opening and closing pairs.
> That does look a bit weird for C and shell users ;)
In some fonts, ` is actually symmetrical to '.
If you change it to 'background_thresh', it will look like crap in my
Sütterlin emacs.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] unmapped quotes
2012-05-12 14:09 ` Johannes Weiner
@ 2012-05-13 2:18 ` Cong Wang
0 siblings, 0 replies; 6+ messages in thread
From: Cong Wang @ 2012-05-13 2:18 UTC (permalink / raw)
To: Johannes Weiner
Cc: Fengguang Wu, Michael Tokarev, liwp.linux, Jan Kara,
Andrew Morton, Peter Zijlstra, linux-kernel, Wanpeng Li
On Sat, May 12, 2012 at 10:09 PM, Johannes Weiner <jweiner@redhat.com> wrote:
> On Sat, May 12, 2012 at 07:26:37PM +0800, Fengguang Wu wrote:
>> On Sat, May 12, 2012 at 01:02:36PM +0400, Michael Tokarev wrote:
>> > On 12.05.2012 12:47, liwp.linux@gmail.com wrote:
>> > > - * If we're over `background_thresh' then the writeback threads are woken to
>> > > + * If we're over 'background_thresh' then the writeback threads are woken to
>> >
>> > I can't say the original is wrong. Since these quotes don't have
>> > "open" and "close" versions like {} or () pairs does, people often
>> > use ` as opening and ' as closing - while staying within ascii.
>> > Alternatives are things like « » or other things, but these aren't
>> > ascii anymore. So I'd say keep it alone... ;)
>>
>> Agreed. For example, latex uses ` and ' as opening and closing pairs.
>> That does look a bit weird for C and shell users ;)
>
> In some fonts, ` is actually symmetrical to '.
>
> If you change it to 'background_thresh', it will look like crap in my
> Sütterlin emacs.
Yup, see also,
http://english.stackexchange.com/questions/17695/any-reference-on-the-usage-of-a-backtick-and-single-quotation-mark-like-this/18669#18669
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] unmapped quotes
2012-05-12 11:26 ` Fengguang Wu
2012-05-12 14:09 ` Johannes Weiner
@ 2012-05-12 14:32 ` Bernd Petrovitsch
1 sibling, 0 replies; 6+ messages in thread
From: Bernd Petrovitsch @ 2012-05-12 14:32 UTC (permalink / raw)
To: Fengguang Wu
Cc: Michael Tokarev, liwp.linux, Jan Kara, Andrew Morton,
Peter Zijlstra, Johannes Weiner, linux-kernel, Wanpeng Li
On Sam, 2012-05-12 at 19:26 +0800, Fengguang Wu wrote:
> On Sat, May 12, 2012 at 01:02:36PM +0400, Michael Tokarev wrote:
> > On 12.05.2012 12:47, liwp.linux@gmail.com wrote:
> > > - * If we're over `background_thresh' then the writeback threads are woken to
> > > + * If we're over 'background_thresh' then the writeback threads are woken to
> >
> > I can't say the original is wrong. Since these quotes don't have
> > "open" and "close" versions like {} or () pairs does, people often
> > use ` as opening and ' as closing - while staying within ascii.
> > Alternatives are things like « » or other things, but these aren't
> > ascii anymore. So I'd say keep it alone... ;)
>
> Agreed. For example, latex uses ` and ' as opening and closing pairs.
m4 too.
> That does look a bit weird for C and shell users ;)
Just because they aren't used to it;-)
And shell scripting would be easier if shells had different opening and
closing quote characters.
Bernd
--
Bernd Petrovitsch Email : bernd@petrovitsch.priv.at
LUGA : http://www.luga.at
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-05-13 2:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-12 8:47 [PATCH] unmapped quotes liwp.linux
2012-05-12 9:02 ` Michael Tokarev
2012-05-12 11:26 ` Fengguang Wu
2012-05-12 14:09 ` Johannes Weiner
2012-05-13 2:18 ` Cong Wang
2012-05-12 14:32 ` Bernd Petrovitsch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).