From: Hiroshi DOYU <hdoyu@nvidia.com>
To: <hdoyu@nvidia.com>
Cc: <linux-tegra@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Stephen Warren <swarren@wwwdotorg.org>,
<linux-kernel@vger.kernel.org>
Subject: [v2 1/1] memory: tegra{20,30}-mc: Use dev_err_ratelimited()
Date: Mon, 14 May 2012 13:07:03 +0300 [thread overview]
Message-ID: <1336990031-15567-1-git-send-email-hdoyu@nvidia.com> (raw)
In-Reply-To: <1336981680-15297-2-git-send-email-hdoyu@nvidia.com>
Introduce a new dev_*_ratelimited() instead of pr_*_ratelimited() for
better info to print.
Signed-off-by: Hiroshi DOYU <hdoyu@nvidia.com>
---
drivers/memory/tegra20-mc.c | 5 +++--
drivers/memory/tegra30-mc.c | 5 +++--
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/memory/tegra20-mc.c b/drivers/memory/tegra20-mc.c
index 2a437e9..a38d9d3 100644
--- a/drivers/memory/tegra20-mc.c
+++ b/drivers/memory/tegra20-mc.c
@@ -161,7 +161,8 @@ static void tegra20_mc_decode(struct tegra20_mc *mc, int n)
idx = n - MC_INT_ERR_SHIFT;
if ((idx < 0) || (idx >= ARRAY_SIZE(reg))) {
- pr_err_ratelimited("Unknown interrupt status %08lx\n", BIT(n));
+ dev_err_ratelimited(mc->dev, "Unknown interrupt status %08lx\n",
+ BIT(n));
return;
}
@@ -172,7 +173,7 @@ static void tegra20_mc_decode(struct tegra20_mc *mc, int n)
addr = mc_readl(mc, reg[idx].offset + sizeof(u32));
- pr_err_ratelimited("%s (0x%08x): 0x%08x %s (%s %s)\n",
+ dev_err_ratelimited(mc->dev, "%s (0x%08x): 0x%08x %s (%s %s)\n",
reg[idx].message, req, addr, client,
(req & BIT(reg[idx].write_bit)) ? "write" : "read",
(reg[idx].offset == MC_SECURITY_VIOLATION_STATUS) ?
diff --git a/drivers/memory/tegra30-mc.c b/drivers/memory/tegra30-mc.c
index ec9fc78..cb639b1 100644
--- a/drivers/memory/tegra30-mc.c
+++ b/drivers/memory/tegra30-mc.c
@@ -220,7 +220,8 @@ static void tegra30_mc_decode(struct tegra30_mc *mc, int n)
idx = n - MC_INT_ERR_SHIFT;
if ((idx < 0) || (idx >= ARRAY_SIZE(mc_int_err)) || (idx == 1)) {
- pr_err_ratelimited("Unknown interrupt status %08lx\n", BIT(n));
+ dev_err_ratelimited(mc->dev, "Unknown interrupt status %08lx\n",
+ BIT(n));
return;
}
@@ -243,7 +244,7 @@ static void tegra30_mc_decode(struct tegra30_mc *mc, int n)
addr = readl(mc + MC_ERR_ADR);
- pr_err_ratelimited("%s (0x%08x): 0x%08x %s (%s %s %s %s)\n",
+ dev_err_ratelimited(mc->dev, "%s (0x%08x): 0x%08x %s (%s %s %s %s)\n",
mc_int_err[idx], err, addr, client,
(err & MC_ERR_SECURITY) ? "secure" : "non-secure",
(err & MC_ERR_RW) ? "write" : "read",
--
1.7.5.4
next prev parent reply other threads:[~2012-05-14 10:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-12 10:52 [RFC 1/1] driver core: Add dev_*_ratelimited() family Hiroshi Doyu
2012-05-12 11:32 ` Bernd Petrovitsch
2012-05-12 15:31 ` Joe Perches
2012-05-14 5:00 ` Hiroshi Doyu
2012-05-14 5:25 ` Joe Perches
2012-05-14 5:40 ` Hiroshi Doyu
2012-05-14 6:05 ` Joe Perches
2012-05-14 7:45 ` Hiroshi Doyu
2012-05-14 7:47 ` [PATCH 1/2] " Hiroshi DOYU
2012-05-14 7:47 ` [PATCH 2/2] memory: tegra{20,30}-mc: Use dev_err_ratelimited() Hiroshi DOYU
2012-05-14 10:07 ` Hiroshi DOYU [this message]
2012-05-14 18:33 ` [v2 1/1] " Stephen Warren
2012-05-14 18:57 ` Hiroshi Doyu
2012-05-14 19:09 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336990031-15567-1-git-send-email-hdoyu@nvidia.com \
--to=hdoyu@nvidia.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).