From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756826Ab2ENPCa (ORCPT ); Mon, 14 May 2012 11:02:30 -0400 Received: from g1t0027.austin.hp.com ([15.216.28.34]:27819 "EHLO g1t0027.austin.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755780Ab2ENPC3 (ORCPT ); Mon, 14 May 2012 11:02:29 -0400 Message-ID: <1337007747.2476.2.camel@lorien2> Subject: Re: [PATCH RESEND] x86: kernel/dumpstack.c simple_strtoul cleanup From: Shuah Khan Reply-To: shuahkhan@gmail.com To: mingo@redhat.com Cc: shuahkhan@gmail.com, hpa@zytor.com, tglx@linutronix.de, "linux-kernel@vger.kernel.org" Date: Mon, 14 May 2012 09:02:27 -0600 In-Reply-To: <1336327084.2897.15.camel@lorien2> References: <1336327084.2897.15.camel@lorien2> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2012-05-06 at 11:58 -0600, Shuah Khan wrote: > Change kstack_setup() and code_bytes_setup() in kernel/dumpstack.c > to call kstrtoul() instead of calling obsoleted simple_strtoul(). > How about this patch? Are you not interested in this type of cleanup patches? Looking for some feedback so I can spend my energies on something that would be worth while :) -- Shuah > > Signed-off-by: Shuah Khan > --- > arch/x86/kernel/dumpstack.c | 21 +++++++++++++++++++-- > 1 files changed, 19 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel/dumpstack.c > index 1b81839..b154f6d 100644 > --- a/arch/x86/kernel/dumpstack.c > +++ b/arch/x86/kernel/dumpstack.c > @@ -311,16 +311,33 @@ void die(const char *str, struct pt_regs *regs, long err) > > static int __init kstack_setup(char *s) > { > + ssize_t ret; > + unsigned long val; > + > if (!s) > return -EINVAL; > - kstack_depth_to_print = simple_strtoul(s, NULL, 0); > + > + ret = kstrtoul(s, 0, &val); > + if (ret) > + return ret; > + kstack_depth_to_print = val; > return 0; > } > early_param("kstack", kstack_setup); > > static int __init code_bytes_setup(char *s) > { > - code_bytes = simple_strtoul(s, NULL, 0); > + ssize_t ret; > + unsigned long val; > + > + if (!s) > + return -EINVAL; > + > + ret = kstrtoul(s, 0, &val); > + if (ret) > + return ret; > + > + code_bytes = val; > if (code_bytes > 8192) > code_bytes = 8192; >