From: Hiroshi DOYU <hdoyu@nvidia.com>
To: <hdoyu@nvidia.com>
Cc: <linux-tegra@vger.kernel.org>,
Joerg Roedel <joerg.roedel@amd.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Bharat Nihalani <bnihalani@nvidia.com>,
Vandana Salve <vsalve@nvidia.com>, <linux-kernel@vger.kernel.org>
Subject: [PATCH 1/2] iommu/tegra: gart: Remove unnecessary cleanup with devm_*()
Date: Mon, 14 May 2012 21:12:02 +0300 [thread overview]
Message-ID: <1337019127-6863-1-git-send-email-hdoyu@nvidia.com> (raw)
Remove unnecessary cleanup procedures with devm_*().
Signed-off-by: Hiroshi DOYU <hdoyu@nvidia.com>
---
drivers/iommu/tegra-gart.c | 22 +++-------------------
1 files changed, 3 insertions(+), 19 deletions(-)
diff --git a/drivers/iommu/tegra-gart.c b/drivers/iommu/tegra-gart.c
index 0c0a377..33a23b6 100644
--- a/drivers/iommu/tegra-gart.c
+++ b/drivers/iommu/tegra-gart.c
@@ -345,7 +345,6 @@ static int tegra_gart_probe(struct platform_device *pdev)
struct gart_device *gart;
struct resource *res, *res_remap;
void __iomem *gart_regs;
- int err;
struct device *dev = &pdev->dev;
if (gart_handle)
@@ -370,8 +369,7 @@ static int tegra_gart_probe(struct platform_device *pdev)
gart_regs = devm_ioremap(dev, res->start, resource_size(res));
if (!gart_regs) {
dev_err(dev, "failed to remap GART registers\n");
- err = -ENXIO;
- goto fail;
+ return -ENXIO;
}
gart->dev = &pdev->dev;
@@ -385,8 +383,7 @@ static int tegra_gart_probe(struct platform_device *pdev)
gart->savedata = vmalloc(sizeof(u32) * gart->page_count);
if (!gart->savedata) {
dev_err(dev, "failed to allocate context save area\n");
- err = -ENOMEM;
- goto fail;
+ return -ENOMEM;
}
platform_set_drvdata(pdev, gart);
@@ -394,27 +391,14 @@ static int tegra_gart_probe(struct platform_device *pdev)
gart_handle = gart;
return 0;
-
-fail:
- if (gart_regs)
- devm_iounmap(dev, gart_regs);
- if (gart && gart->savedata)
- vfree(gart->savedata);
- devm_kfree(dev, gart);
- return err;
}
static int tegra_gart_remove(struct platform_device *pdev)
{
struct gart_device *gart = platform_get_drvdata(pdev);
- struct device *dev = gart->dev;
writel(0, gart->regs + GART_CONFIG);
- if (gart->savedata)
- vfree(gart->savedata);
- if (gart->regs)
- devm_iounmap(dev, gart->regs);
- devm_kfree(dev, gart);
+ vfree(gart->savedata);
gart_handle = NULL;
return 0;
}
--
1.7.5.4
next reply other threads:[~2012-05-14 18:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 18:12 Hiroshi DOYU [this message]
2012-05-14 18:12 ` [PATCH 2/2] iommu/tegra: gart: Reserve iomem resource Hiroshi DOYU
2012-05-21 14:11 ` Thierry Reding
2012-05-21 16:41 ` Stephen Warren
2012-05-21 17:05 ` Lucas Stach
2012-05-21 17:14 ` Stephen Warren
2012-05-21 17:31 ` Thierry Reding
2012-05-21 17:38 ` Lucas Stach
2012-06-18 10:37 ` Hiroshi Doyu
2012-06-18 21:14 ` Lucas Stach
2012-05-21 17:38 ` Thierry Reding
2012-05-21 14:16 ` [PATCH 1/2] iommu/tegra: gart: Remove unnecessary cleanup with devm_*() Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337019127-6863-1-git-send-email-hdoyu@nvidia.com \
--to=hdoyu@nvidia.com \
--cc=bnihalani@nvidia.com \
--cc=joerg.roedel@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=vsalve@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox