From: Joe Perches <joe@perches.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: Fix boot on Twinhead H12Y
Date: Tue, 15 May 2012 09:52:07 -0700 [thread overview]
Message-ID: <1337100727.7050.17.camel@joe2Laptop> (raw)
In-Reply-To: <20120515174347.5109.94551.stgit@bluebook>
On Tue, 2012-05-15 at 18:44 +0100, Alan Cox wrote:
> Despite lots of investigation into why this is needed we don't know or have
> an elegant cure. The only answer found on this laptop is to mark a problem
> region as used so that Linux doesn't put anything there.
trivia:
> diff --git a/arch/x86/pci/fixup.c b/arch/x86/pci/fixup.c
[]
> @@ -519,3 +519,22 @@ static void sb600_disable_hpet_bar(struct pci_dev *dev)
[]
> +static void __devinit twinhead_reserve_killing_zone(struct pci_dev *dev)
> +{
> + if (dev->subsystem_vendor == 0x14FF && dev->subsystem_device ==
> + 0xA003) {
Doesn't this look ugly to you?
Doesn't
if (dev->subsystem_vendor == 0x14FF &&
dev->subsystem_device == 0xA003) {
at least read more easily?
next prev parent reply other threads:[~2012-05-15 16:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 17:44 [PATCH] x86: Fix boot on Twinhead H12Y Alan Cox
2012-05-15 16:52 ` Joe Perches [this message]
2012-05-15 17:09 ` Alan Cox
2012-05-17 18:22 ` [tip:x86/urgent] " tip-bot for Alan Cox
2012-05-17 18:29 ` H. Peter Anvin
2012-05-17 19:56 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337100727.7050.17.camel@joe2Laptop \
--to=joe@perches.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox