From: "Yan, Zheng" <zheng.z.yan@intel.com>
To: a.p.zijlstra@chello.nl, mingo@elte.hu, andi@firstfloor.org,
eranian@google.com, jolsa@redhat.com, ming.m.lin@intel.com,
gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 02/10] perf: Avoid race between cpu hotplug and installing event
Date: Wed, 16 May 2012 12:59:55 +0800 [thread overview]
Message-ID: <1337144403-30841-3-git-send-email-zheng.z.yan@intel.com> (raw)
In-Reply-To: <1337144403-30841-1-git-send-email-zheng.z.yan@intel.com>
From: "Yan, Zheng" <zheng.z.yan@intel.com>
perf_event_open requires the cpu on which to install event is online,
but the cpu can go offline after perf_event_open checks that. Add
get_online_cpus()/put_online_cpus() pair to avoid the race.
Signed-off-by: Zheng Yan <zheng.z.yan@intel.com>
---
kernel/events/core.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/kernel/events/core.c b/kernel/events/core.c
index 91a4459..9fdf394 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -6255,6 +6255,8 @@ SYSCALL_DEFINE5(perf_event_open,
}
}
+ get_online_cpus();
+
event = perf_event_alloc(&attr, cpu, task, group_leader, NULL,
NULL, NULL);
if (IS_ERR(event)) {
@@ -6394,6 +6396,8 @@ SYSCALL_DEFINE5(perf_event_open,
perf_unpin_context(ctx);
mutex_unlock(&ctx->mutex);
+ put_online_cpus();
+
event->owner = current;
mutex_lock(¤t->perf_event_mutex);
@@ -6422,6 +6426,7 @@ SYSCALL_DEFINE5(perf_event_open,
err_alloc:
free_event(event);
err_task:
+ put_online_cpus();
if (task)
put_task_struct(task);
err_group_fd:
--
1.7.7.6
next prev parent reply other threads:[~2012-05-16 5:00 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-16 4:59 [PATCH V4 0/10] perf: Intel uncore pmu counting support Yan, Zheng
2012-05-16 4:59 ` [PATCH 01/10] perf: Export perf_assign_events Yan, Zheng
2012-05-16 4:59 ` Yan, Zheng [this message]
2012-05-16 4:59 ` [PATCH 03/10] perf: Allow pmu to choose cpu on which to install event Yan, Zheng
2012-05-16 4:59 ` [PATCH 04/10] perf: Introduce perf_pmu_migrate_context Yan, Zheng
2012-05-16 4:59 ` [PATCH 05/10] perf: Generic intel uncore support Yan, Zheng
2012-05-16 4:59 ` [PATCH 06/10] perf: Add Nehalem and Sandy Bridge " Yan, Zheng
2012-05-16 5:00 ` [PATCH 07/10] perf: Generic pci uncore device support Yan, Zheng
2012-05-16 5:00 ` [PATCH 08/10] perf: Add Sandy Bridge-EP uncore support Yan, Zheng
2012-05-16 5:00 ` [PATCH 09/10] perf tool: Make the event parser reentrantable Yan, Zheng
2012-05-16 5:00 ` [PATCH 10/10] perf tool: Add pmu event alias support Yan, Zheng
2012-05-21 7:36 ` [RFC 0/5] perf, tool: uncore related changes Jiri Olsa
2012-05-21 7:36 ` [PATCH 1/5] perf, tool: Use data struct for arg passing in event parse function Jiri Olsa
2012-05-21 7:36 ` [PATCH 2/5] perf, tool: Make the event parser reentrantable Jiri Olsa
2012-05-21 7:36 ` [PATCH 3/5] perf, tool: Add support to reuse event grammar to parse out terms Jiri Olsa
2012-05-21 7:36 ` [PATCH 4/5] perf, tool: Add pmu event alias support Jiri Olsa
2012-05-21 7:36 ` [PATCH 5/5] perf, tool: Add automated test for pure terms parsing Jiri Olsa
2012-05-21 8:22 ` [RFC 0/5] perf, tool: uncore related changes Jiri Olsa
2012-05-23 14:53 ` Stephane Eranian
2012-05-23 15:16 ` Jiri Olsa
2012-05-23 15:21 ` Stephane Eranian
2012-05-23 15:28 ` Jiri Olsa
2012-06-04 9:35 ` [PATCH V4 0/10] perf: Intel uncore pmu counting support Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337144403-30841-3-git-send-email-zheng.z.yan@intel.com \
--to=zheng.z.yan@intel.com \
--cc=a.p.zijlstra@chello.nl \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).