* [PATCH] regulator: max8925: Remove check_range function and max_uV from struct rc5t583_regulator_info
@ 2012-05-17 0:55 Axel Lin
2012-05-17 22:01 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2012-05-17 0:55 UTC (permalink / raw)
To: linux-kernel; +Cc: Haojian Zhuang, Liam Girdwood, Mark Brown
This driver has been converted to use regulator_map_voltage_linear and
set_voltage_sel now. regulator_map_voltage_linear will check the the voltage
falls within specified range. The check_range() function and max_uV field are
not used now, remove them.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/regulator/max8925-regulator.c | 12 ------------
1 files changed, 0 insertions(+), 12 deletions(-)
diff --git a/drivers/regulator/max8925-regulator.c b/drivers/regulator/max8925-regulator.c
index 0ffcb55..43dc97ec 100644
--- a/drivers/regulator/max8925-regulator.c
+++ b/drivers/regulator/max8925-regulator.c
@@ -38,20 +38,10 @@ struct max8925_regulator_info {
struct i2c_client *i2c;
struct max8925_chip *chip;
- int max_uV;
int vol_reg;
int enable_reg;
};
-static inline int check_range(struct max8925_regulator_info *info,
- int min_uV, int max_uV)
-{
- if (min_uV < info->desc.min_uV || min_uV > info->max_uV)
- return -EINVAL;
-
- return 0;
-}
-
static int max8925_set_voltage_sel(struct regulator_dev *rdev,
unsigned int selector)
{
@@ -177,7 +167,6 @@ static struct regulator_ops max8925_regulator_ldo_ops = {
.min_uV = min * 1000, \
.uV_step = step * 1000, \
}, \
- .max_uV = max * 1000, \
.vol_reg = MAX8925_SDV##_id, \
.enable_reg = MAX8925_SDCTL##_id, \
}
@@ -194,7 +183,6 @@ static struct regulator_ops max8925_regulator_ldo_ops = {
.min_uV = min * 1000, \
.uV_step = step * 1000, \
}, \
- .max_uV = max * 1000, \
.vol_reg = MAX8925_LDOVOUT##_id, \
.enable_reg = MAX8925_LDOCTL##_id, \
}
--
1.7.5.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] regulator: max8925: Remove check_range function and max_uV from struct rc5t583_regulator_info
2012-05-17 0:55 [PATCH] regulator: max8925: Remove check_range function and max_uV from struct rc5t583_regulator_info Axel Lin
@ 2012-05-17 22:01 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2012-05-17 22:01 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Haojian Zhuang, Liam Girdwood
[-- Attachment #1: Type: text/plain, Size: 337 bytes --]
On Thu, May 17, 2012 at 08:55:45AM +0800, Axel Lin wrote:
> This driver has been converted to use regulator_map_voltage_linear and
> set_voltage_sel now. regulator_map_voltage_linear will check the the voltage
> falls within specified range. The check_range() function and max_uV field are
> not used now, remove them.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-05-17 22:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-17 0:55 [PATCH] regulator: max8925: Remove check_range function and max_uV from struct rc5t583_regulator_info Axel Lin
2012-05-17 22:01 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox