public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu,
	laijs@cn.fujitsu.com, dipankar@in.ibm.com,
	akpm@linux-foundation.org, mathieu.desnoyers@polymtl.ca,
	josh@joshtriplett.org, niv@us.ibm.com, tglx@linutronix.de,
	rostedt@goodmis.org, Valdis.Kletnieks@vt.edu,
	dhowells@redhat.com, eric.dumazet@gmail.com, darren@dvhart.com,
	fweisbec@gmail.com, patches@linaro.org
Subject: Re: [PATCH RFC tip/core/rcu 2/2] rcu: Fix broken strings in RCU's source code.
Date: Fri, 18 May 2012 00:27:31 +0200	[thread overview]
Message-ID: <1337293651.4281.114.camel@twins> (raw)
In-Reply-To: <1337292765-12221-2-git-send-email-paulmck@linux.vnet.ibm.com>

On Thu, 2012-05-17 at 15:12 -0700, Paul E. McKenney wrote:
>         cnt += sprintf(&page[cnt],
> -                      "rtc: %p ver: %lu tfle: %d rta: %d rtaf: %d rtf: %d "
> -                      "rtmbe: %d rtbke: %ld rtbre: %ld "
> -                      "rtbf: %ld rtb: %ld nt: %ld "
> -                      "onoff: %ld/%ld:%ld/%ld "
> -                      "barrier: %ld/%ld:%ld",

The paranoid side of me would've used:

	cnt += snprintf(page + cnt, PAGE_SIZE - cnt, ...);



  parent reply	other threads:[~2012-05-17 22:28 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-17 22:12 [PATCH tip/core/rcu 0/2] Code-style fixes Paul E. McKenney
2012-05-17 22:12 ` [PATCH RFC tip/core/rcu 1/2] rcu: Fix code-style issues involving "else" Paul E. McKenney
2012-05-17 22:12   ` [PATCH RFC tip/core/rcu 2/2] rcu: Fix broken strings in RCU's source code Paul E. McKenney
2012-05-17 22:20     ` Peter Zijlstra
2012-05-17 22:32       ` Josh Triplett
2012-05-17 22:32       ` Paul Bolle
2012-05-18  6:33       ` Ingo Molnar
2012-05-18 12:33         ` Paul E. McKenney
2012-05-17 22:23     ` Josh Triplett
2012-05-17 22:41       ` Paul E. McKenney
2012-05-17 22:27     ` Peter Zijlstra [this message]
2012-05-17 22:43       ` Paul E. McKenney
2012-05-17 22:24   ` [PATCH RFC tip/core/rcu 1/2] rcu: Fix code-style issues involving "else" Josh Triplett
2012-05-18  7:38   ` Lai Jiangshan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1337293651.4281.114.camel@twins \
    --to=peterz@infradead.org \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=akpm@linux-foundation.org \
    --cc=darren@dvhart.com \
    --cc=dhowells@redhat.com \
    --cc=dipankar@in.ibm.com \
    --cc=eric.dumazet@gmail.com \
    --cc=fweisbec@gmail.com \
    --cc=josh@joshtriplett.org \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@polymtl.ca \
    --cc=mingo@elte.hu \
    --cc=niv@us.ibm.com \
    --cc=patches@linaro.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox