public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Konstantin Khlebnikov <khlebnikov@openvz.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Ingo Molnar <mingo@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] sched: taint kernel with TAINT_WARN after sleep-in-atomic bug
Date: Fri, 18 May 2012 10:54:14 +0200	[thread overview]
Message-ID: <1337331254.573.1.camel@twins> (raw)
In-Reply-To: <20120510122004.4873.12726.stgit@zurg>

On Thu, 2012-05-10 at 16:20 +0400, Konstantin Khlebnikov wrote:
> Usually sleep-in-atomic bugs are followed by dozens other warnings.
> This patch should help to figure out original source of problem.
> 
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@openvz.org>

Thanks!

> ---
>  kernel/sched/core.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 0533a68..b6458e4 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -3113,6 +3113,7 @@ static noinline void __schedule_bug(struct task_struct *prev)
>  	if (irqs_disabled())
>  		print_irqtrace_events(prev);
>  	dump_stack();
> +	add_taint(TAINT_WARN);
>  }
>  
>  /*
> 


  reply	other threads:[~2012-05-18  8:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-10  7:54 [PATCH] sched: set TAINT_UNSAFE_SMP after sleep-in-atomic bug Konstantin Khlebnikov
2012-05-10 10:01 ` Peter Zijlstra
2012-05-10 10:56   ` Konstantin Khlebnikov
2012-05-10 11:46     ` Peter Zijlstra
2012-05-10 12:20       ` [PATCH v2] sched: taint kernel with TAINT_WARN " Konstantin Khlebnikov
2012-05-18  8:54         ` Peter Zijlstra [this message]
2012-05-18 11:16         ` [tip:sched/core] sched: Taint " tip-bot for Konstantin Khlebnikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1337331254.573.1.camel@twins \
    --to=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=khlebnikov@openvz.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox