From: Peter Zijlstra <peterz@infradead.org>
To: Borislav Petkov <bp@amd64.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@elte.hu>, Steven Rostedt <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>,
Borislav Petkov <borislav.petkov@amd.com>
Subject: Re: [PATCH 1/2] perf: Add persistent event facilities
Date: Fri, 18 May 2012 16:37:37 +0200 [thread overview]
Message-ID: <1337351857.573.47.camel@twins> (raw)
In-Reply-To: <20120518142131.GO20215@aftab.osrc.amd.com>
On Fri, 2012-05-18 at 16:21 +0200, Borislav Petkov wrote:
> On Fri, May 18, 2012 at 04:14:22PM +0200, Peter Zijlstra wrote:
> > On Fri, 2012-05-18 at 16:09 +0200, Borislav Petkov wrote:
> > > What happens here if a second user wants to enable a second set of
> > > persistent events, allocate a second set of per-CPU buffers?
> >
> > I'm not seeing the relation to VM_SHARED here.
>
> Well, in the sense that if mmap fails in the !VM_SHARED case, I can't
> enable any persistent events except the ones which are enabled and so
> I need to allocate another set of resources for that second persistent
> events user.
Right, well, you could actually allow operations on the fd, just not a
second mapping :-)
Anyway.. I'd push that error back to the user. If they need a second
set, let them create it.
Do you really need multiple consumers for your MCE stuff? If so, what
would be the problem of using VM_SHARED?
next prev parent reply other threads:[~2012-05-18 14:37 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-21 14:34 [RFC PATCH 0/2] perf: Add persistent event facilities Borislav Petkov
2012-03-21 14:34 ` [PATCH 1/2] " Borislav Petkov
2012-05-18 9:58 ` Peter Zijlstra
2012-05-18 10:01 ` Borislav Petkov
2012-05-18 10:00 ` Peter Zijlstra
2012-05-18 10:02 ` Peter Zijlstra
2012-05-18 10:09 ` Peter Zijlstra
2012-05-18 10:49 ` Borislav Petkov
2012-05-18 10:14 ` Peter Zijlstra
2012-05-18 11:03 ` Borislav Petkov
2012-05-18 11:24 ` Peter Zijlstra
2012-05-18 11:59 ` Ingo Molnar
2012-05-18 12:55 ` Borislav Petkov
2012-05-18 13:37 ` Peter Zijlstra
2012-05-18 14:09 ` Borislav Petkov
2012-05-18 14:14 ` Peter Zijlstra
2012-05-18 14:21 ` Borislav Petkov
2012-05-18 14:37 ` Peter Zijlstra [this message]
2012-05-18 15:24 ` Borislav Petkov
2012-05-31 17:33 ` Borislav Petkov
2012-03-21 14:34 ` [PATCH 2/2] x86, mce: Add persistent MCE event Borislav Petkov
2012-03-22 8:36 ` Srivatsa S. Bhat
2012-03-22 11:40 ` Borislav Petkov
2012-03-22 11:57 ` Srivatsa S. Bhat
2012-03-23 12:31 ` Ingo Molnar
2012-03-23 13:30 ` Borislav Petkov
2012-03-24 7:37 ` Ingo Molnar
2012-03-24 9:00 ` Borislav Petkov
2012-03-24 9:15 ` Ingo Molnar
2012-05-15 15:32 ` Borislav Petkov
2012-05-18 8:18 ` Ingo Molnar
2012-05-18 10:03 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337351857.573.47.camel@twins \
--to=peterz@infradead.org \
--cc=borislav.petkov@amd.com \
--cc=bp@amd64.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox