From: Joe Perches <joe@perches.com>
To: David Rientjes <rientjes@google.com>
Cc: Nasir Abed <nasirabed@gmail.com>,
gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, swetland@google.com,
Nasir Abed <nasirabed+kernel@gmail.com>
Subject: Re: [PATCH] Staging: android: alarm: fixed quoted string split across lines
Date: Sun, 20 May 2012 13:38:04 -0700 [thread overview]
Message-ID: <1337546284.31503.5.camel@joe2Laptop> (raw)
In-Reply-To: <alpine.DEB.2.00.1205201328170.10189@chino.kir.corp.google.com>
On Sun, 2012-05-20 at 13:28 -0700, David Rientjes wrote:
> On Sun, 20 May 2012, Nasir Abed wrote:
>
> > diff --git a/drivers/staging/android/alarm.c b/drivers/staging/android/alarm.c
> > index c68950b..4ea07bb 100644
> > --- a/drivers/staging/android/alarm.c
> > +++ b/drivers/staging/android/alarm.c
> > @@ -302,8 +302,8 @@ int android_alarm_set_rtc(struct timespec new_time)
> > }
> > ret = rtc_set_time(alarm_rtc_dev, &rtc_new_rtc_time);
> > if (ret < 0)
> > - pr_alarm(ERROR, "alarm_set_rtc: "
> > - "Failed to set RTC, time will be lost on reboot\n");
> > + pr_alarm(ERROR,
> > + "alarm_set_rtc: Failed to set RTC, time will be lost on reboot\n");
> > err:
> > wake_unlock(&alarm_rtc_wake_lock);
> > mutex_unlock(&alarm_setrtc_mutex);
>
> Looks like this would benefit from using __func__ since it already doesn't
> represent the correct function name.
true.
Somewhat related, pr_alarm is a poor name choice.
It should probably called alarm_dbg.
o it's a duplicated #define
it should be in some common #include
o it's a debug test that emits at KERN_INFO
next prev parent reply other threads:[~2012-05-20 20:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-20 9:54 [PATCH] Staging: android: alarm: fixed quoted string split across lines Nasir Abed
2012-05-20 14:17 ` Dan Carpenter
2012-05-20 14:20 ` Nasir Abed
2012-05-20 15:10 ` Dan Carpenter
2012-05-20 20:28 ` David Rientjes
2012-05-20 20:38 ` Joe Perches [this message]
2012-05-20 21:06 ` [PATCH] Staging: android: alarm: Rename pr_alarm to alarm_dbg Joe Perches
2012-05-20 21:26 ` David Rientjes
2012-05-21 10:49 ` Nasir Abed
2012-05-21 11:37 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337546284.31503.5.camel@joe2Laptop \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nasirabed+kernel@gmail.com \
--cc=nasirabed@gmail.com \
--cc=rientjes@google.com \
--cc=swetland@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox