From: Shuah Khan <shuahkhan@gmail.com>
To: muli@il.ibm.com, jdmason@kudzu.us, tglx@linutronix.de,
mingo@redhat.com, hpa@zytor.com
Cc: shuahkhan@gmail.com, x86@kernel.org, discuss@x86-64.org,
LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] x86: kernel/pci-calgary_64.c simple_strtoul cleanup
Date: Sun, 20 May 2012 17:24:28 -0600 [thread overview]
Message-ID: <1337556268.3126.5.camel@lorien2> (raw)
Change calgary_parse_options() to call kstrtoul() instead of calling
obsoleted simple_strtoul().
Signed-off-by: Shuah Khan <shuahkhan@gmail.com>
---
arch/x86/kernel/pci-calgary_64.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/arch/x86/kernel/pci-calgary_64.c b/arch/x86/kernel/pci-calgary_64.c
index d0b2fb9..b72838b 100644
--- a/arch/x86/kernel/pci-calgary_64.c
+++ b/arch/x86/kernel/pci-calgary_64.c
@@ -1480,8 +1480,9 @@ cleanup:
static int __init calgary_parse_options(char *p)
{
unsigned int bridge;
+ unsigned long val;
size_t len;
- char* endp;
+ ssize_t ret;
while (*p) {
if (!strncmp(p, "64k", 3))
@@ -1512,10 +1513,11 @@ static int __init calgary_parse_options(char *p)
++p;
if (*p == '\0')
break;
- bridge = simple_strtoul(p, &endp, 0);
- if (p == endp)
+ ret = kstrtoul(p, 0, &val);
+ if (ret)
break;
+ bridge = val;
if (bridge < MAX_PHB_BUS_NUM) {
printk(KERN_INFO "Calgary: disabling "
"translation for PHB %#x\n", bridge);
--
1.7.9.5
next reply other threads:[~2012-05-20 23:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-20 23:24 Shuah Khan [this message]
2012-05-21 6:00 ` [PATCH] x86: kernel/pci-calgary_64.c simple_strtoul cleanup Muli Ben-Yehuda
2012-05-21 9:47 ` [tip:x86/cleanups] x86/pci-calgary_64.c: Remove obsoleted simple_strtoul() usage tip-bot for Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337556268.3126.5.camel@lorien2 \
--to=shuahkhan@gmail.com \
--cc=discuss@x86-64.org \
--cc=hpa@zytor.com \
--cc=jdmason@kudzu.us \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=muli@il.ibm.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox