From: Jiri Olsa <jolsa@redhat.com>
To: zheng.z.yan@intel.com
Cc: a.p.zijlstra@chello.nl, mingo@elte.hu, andi@firstfloor.org,
eranian@google.com, jolsa@redhat.com, ming.m.lin@intel.com,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: [RFC 0/5] perf, tool: uncore related changes
Date: Mon, 21 May 2012 09:36:48 +0200 [thread overview]
Message-ID: <1337585813-3349-1-git-send-email-jolsa@redhat.com> (raw)
In-Reply-To: <1337144403-30841-1-git-send-email-zheng.z.yan@intel.com>
hi,
this patchset is based on parsing fixies I just sent out
and CC-ed you.
I found a way to reuse the event parsing grammar for just
term parsing. I had to make some other changes as well:
- we end up with 2 start symbols for event grammar to differentiate
between event parsing and terms parsing
- we have now 2 diferent structures with parser arguments
for each event parsing and terms parsing
- I kept the reentrant parser.. it's not needed but I think
it's better than non reentrant ;)
I'm passing yyscanner instead of yylval and yytext as you did,
because you can get yylval and yytext out of yyscanner,
also I think it's more generic
- added automated tests for terms parsing, but we need automated
tests for term aliasing (patch 4/5) .. similar pmu tests as
for pmu format parsing
attached patches:
1/5 perf, tool: Use data struct for arg passing in event parse function
2/5 perf, tool: Make the event parser reentrantable
3/5 perf, tool: Add support to reuse event grammar to parse out terms
4/5 perf, tool: Add pmu event alias support
5/5 perf, tool: Add automated test for pure terms parsing
thanks for comments,
jirka
---
tools/perf/util/parse-events-test.c | 122 +++++++++++++++++++++++++++-
tools/perf/util/parse-events.c | 71 ++++++++++++++---
tools/perf/util/parse-events.h | 15 +++-
tools/perf/util/parse-events.l | 129 ++++++++++++++++++-----------
tools/perf/util/parse-events.y | 71 ++++++++++++-----
tools/perf/util/pmu.c | 152 +++++++++++++++++++++++++++++++++++
tools/perf/util/pmu.h | 11 +++-
7 files changed, 483 insertions(+), 88 deletions(-)
next prev parent reply other threads:[~2012-05-21 7:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-16 4:59 [PATCH V4 0/10] perf: Intel uncore pmu counting support Yan, Zheng
2012-05-16 4:59 ` [PATCH 01/10] perf: Export perf_assign_events Yan, Zheng
2012-05-16 4:59 ` [PATCH 02/10] perf: Avoid race between cpu hotplug and installing event Yan, Zheng
2012-05-16 4:59 ` [PATCH 03/10] perf: Allow pmu to choose cpu on which to install event Yan, Zheng
2012-05-16 4:59 ` [PATCH 04/10] perf: Introduce perf_pmu_migrate_context Yan, Zheng
2012-05-16 4:59 ` [PATCH 05/10] perf: Generic intel uncore support Yan, Zheng
2012-05-16 4:59 ` [PATCH 06/10] perf: Add Nehalem and Sandy Bridge " Yan, Zheng
2012-05-16 5:00 ` [PATCH 07/10] perf: Generic pci uncore device support Yan, Zheng
2012-05-16 5:00 ` [PATCH 08/10] perf: Add Sandy Bridge-EP uncore support Yan, Zheng
2012-05-16 5:00 ` [PATCH 09/10] perf tool: Make the event parser reentrantable Yan, Zheng
2012-05-16 5:00 ` [PATCH 10/10] perf tool: Add pmu event alias support Yan, Zheng
2012-05-21 7:36 ` Jiri Olsa [this message]
2012-05-21 7:36 ` [PATCH 1/5] perf, tool: Use data struct for arg passing in event parse function Jiri Olsa
2012-05-21 7:36 ` [PATCH 2/5] perf, tool: Make the event parser reentrantable Jiri Olsa
2012-05-21 7:36 ` [PATCH 3/5] perf, tool: Add support to reuse event grammar to parse out terms Jiri Olsa
2012-05-21 7:36 ` [PATCH 4/5] perf, tool: Add pmu event alias support Jiri Olsa
2012-05-21 7:36 ` [PATCH 5/5] perf, tool: Add automated test for pure terms parsing Jiri Olsa
2012-05-21 8:22 ` [RFC 0/5] perf, tool: uncore related changes Jiri Olsa
2012-05-23 14:53 ` Stephane Eranian
2012-05-23 15:16 ` Jiri Olsa
2012-05-23 15:21 ` Stephane Eranian
2012-05-23 15:28 ` Jiri Olsa
2012-06-04 9:35 ` [PATCH V4 0/10] perf: Intel uncore pmu counting support Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337585813-3349-1-git-send-email-jolsa@redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=mingo@elte.hu \
--cc=zheng.z.yan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).