From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752208Ab2EUPVn (ORCPT ); Mon, 21 May 2012 11:21:43 -0400 Received: from charybdis-ext.suse.de ([195.135.221.2]:56358 "EHLO nat.nue.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751484Ab2EUPVl (ORCPT ); Mon, 21 May 2012 11:21:41 -0400 Subject: Re: [PATCH 2/2] drivers-platform-x86: use acpi_video_dmi_promote_vendor() From: joeyli To: Corentin Chary Cc: Len Brown , Richard Purdie , platform-driver-x86@vger.kernel.org, linux-acpi@vger.kernel.org, Zhang Rui , Joey Lee , Matthew Garrett , Corentin Chary , linux-kernel@vger.kernel.org In-Reply-To: <1337585027-4828-2-git-send-email-corentin.chary@gmail.com> References: <1337585027-4828-1-git-send-email-corentin.chary@gmail.com> <1337585027-4828-2-git-send-email-corentin.chary@gmail.com> Content-Type: text/plain; charset="UTF-8" Date: Mon, 21 May 2012 23:17:35 +0800 Message-ID: <1337613455.9751.222.camel@linux-s257.site> Mime-Version: 1.0 X-Mailer: Evolution 2.28.2 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 於 一，2012-05-21 於 09:23 +0200，Corentin Chary 提到： > Instead of using directly acpi_video_unregister(), use > acpi_video_dmi_promote_vendor() (and make it call > acpi_video_unregister() if needed) > > Signed-off-by: Corentin Chary > --- > drivers/platform/x86/acer-wmi.c | 11 ++++------- > drivers/platform/x86/apple-gmux.c | 2 ++ > drivers/platform/x86/samsung-laptop.c | 22 ++++++++++++---------- > 3 files changed, 18 insertions(+), 17 deletions(-) > > diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c > index c1a3fd8..a3f2f1b 100644 > --- a/drivers/platform/x86/acer-wmi.c > +++ b/drivers/platform/x86/acer-wmi.c > @@ -2036,14 +2036,11 @@ static int __init acer_wmi_init(void) > > set_quirks(); > > + if (dmi_check_system(video_vendor_dmi_table)) > + acpi_video_dmi_promote_vendor(); > if (acpi_video_backlight_support()) { > - if (dmi_check_system(video_vendor_dmi_table)) { > - acpi_video_unregister(); > - } else { > - interface->capability &= ~ACER_CAP_BRIGHTNESS; > - pr_info("Brightness must be controlled by " > - "acpi video driver\n"); > - } > + interface->capability &= ~ACER_CAP_BRIGHTNESS; > + pr_info("Brightness must be controlled by acpi video driver\n"); > } > > if (wmi_has_guid(WMID_GUID3)) { Acked-by: Lee, Chun-Yi Thanks a lot! Joey Lee > diff --git a/drivers/platform/x86/apple-gmux.c b/drivers/platform/x86/apple-gmux.c > index 6dcef4f..39e047d 100644 > --- a/drivers/platform/x86/apple-gmux.c > +++ b/drivers/platform/x86/apple-gmux.c > @@ -193,6 +193,7 @@ static int __devinit gmux_probe(struct pnp_dev *pnp, > * backlight control and supports more levels than other options. > * Disable the other backlight choices. > */ > + acpi_video_dmi_promote_vendor(); > acpi_video_unregister(); > apple_bl_unregister(); > > @@ -213,6 +214,7 @@ static void __devexit gmux_remove(struct pnp_dev *pnp) > release_region(gmux_data->iostart, gmux_data->iolen); > kfree(gmux_data); > > + acpi_video_dmi_demote_vendor(); > acpi_video_register(); > apple_bl_register(); > } > diff --git a/drivers/platform/x86/samsung-laptop.c b/drivers/platform/x86/samsung-laptop.c > index e2a34b4..2cbccc1 100644 > --- a/drivers/platform/x86/samsung-laptop.c > +++ b/drivers/platform/x86/samsung-laptop.c > @@ -26,7 +26,7 @@ > #include > #include > #include > -#if (defined CONFIG_ACPI_VIDEO || defined CONFIG_ACPI_VIDEO_MODULE) > +#ifdef CONFIG_ACPI_VIDEO > #include > #endif > > @@ -1530,15 +1530,18 @@ static int __init samsung_init(void) > samsung->quirks = quirks; > > > -#if (defined CONFIG_ACPI_VIDEO || defined CONFIG_ACPI_VIDEO_MODULE) > +#ifdef CONFIG_ACPI > + if (samsung->quirks->broken_acpi_video) > + acpi_video_dmi_promote_vendor(); > + > /* Don't handle backlight here if the acpi video already handle it */ > if (acpi_video_backlight_support()) { > - if (samsung->quirks->broken_acpi_video) { > - pr_info("Disabling ACPI video driver\n"); > - acpi_video_unregister(); > - } else { > - samsung->handle_backlight = false; > - } > + samsung->handle_backlight = false; > + } else if (samsung->quirks->broken_acpi_video) { > + pr_info("Disabling ACPI video driver\n"); > +#ifdef CONFIG_ACPI_VIDEO > + acpi_video_unregister(); > +#endif > } > #endif > > @@ -1552,8 +1555,7 @@ static int __init samsung_init(void) > > #ifdef CONFIG_ACPI > /* Only log that if we are really on a sabi platform */ > - if (acpi_video_backlight_support() && > - !samsung->quirks->broken_acpi_video) > + if (acpi_video_backlight_support()) > pr_info("Backlight controlled by ACPI video driver\n"); > #endif >