From: Shuah Khan <shuah@fc.hp.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Bryan Wu <bryan.wu@canonical.com>,
Richard Purdie <rpurdie@rpsys.net>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
linux-leds@vger.kernel.org
Subject: Re: [PATCH] ARM: leds: Add MAX6956 driver
Date: Mon, 21 May 2012 10:12:03 -0600 [thread overview]
Message-ID: <1337616723.2558.10.camel@lorien2> (raw)
In-Reply-To: <20120521082626.GG3710@pengutronix.de>
On Mon, 2012-05-21 at 10:26 +0200, Uwe Kleine-König wrote:
> > As Shuah said, no kfree(ddata) here
> As Sascha said, it would be wrong to add one.
Thanks. Didn't realize devm_* take care of free at device detach. I am
starting to see patches that make this change to other leds drivers.
Something new to learn. :)
-- Shuah
prev parent reply other threads:[~2012-05-21 16:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-18 15:45 [PATCH] ARM: leds: Add MAX6956 driver Uwe Kleine-König
2012-05-18 19:37 ` Shuah Khan
2012-05-21 6:41 ` Sascha Hauer
2012-05-21 4:50 ` Bryan Wu
2012-05-21 8:26 ` Uwe Kleine-König
2012-05-21 9:41 ` [PATCH v2] " Uwe Kleine-König
2012-05-21 19:33 ` [PATCH v3] " Uwe Kleine-König
2012-05-21 21:30 ` Linus Walleij
2012-05-24 16:17 ` Uwe Kleine-König
2012-05-25 6:55 ` Linus Walleij
2012-06-22 6:06 ` Uwe Kleine-König
2012-05-21 16:12 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337616723.2558.10.camel@lorien2 \
--to=shuah@fc.hp.com \
--cc=bryan.wu@canonical.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=rpurdie@rpsys.net \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox